Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Tizen] Don't SetProcessTitleFromCommandLine. #58

Merged
merged 1 commit into from
Sep 4, 2013
Merged

[Tizen] Don't SetProcessTitleFromCommandLine. #58

merged 1 commit into from
Sep 4, 2013

Conversation

ds-hwang
Copy link
Contributor

@ds-hwang ds-hwang commented Sep 4, 2013

SetProcessTitleFromCommandLine changes process title to absolute path of the
executable.

It has two issues on Tizen.

  1. Tizen task manager can not recognize xwalk process.
  2. Web app uses symbol link to the xwalk executable. Web app process title must
    show symbol link path, not xwalk executable path for the task manager to
    recognize Web app, not XWalk.

@ds-hwang
[Tizen] Don't SetProcessTitleFromCommandLine.
417793b 
SetProcessTitleFromCommandLine changes process title to absolute path of the
executable.

It has two issues on Tizen.
1. Tizen task manager can not recognize xwalk process.
2. Web app uses symbol link to the xwalk executable. Web app process title must
show symbol link path, not xwalk executable path for the task manager to
recognize Web app, not XWalk.
@ds-hwang
Copy link
Contributor Author

ds-hwang commented Sep 4, 2013

crosswalk-project/crosswalk#570 needs this patch to show xwalk item on task manager.

@ds-hwang ds-hwang mentioned this pull request Sep 4, 2013
Closed
kenchris pushed a commit that referenced this pull request Sep 4, 2013
Merge pull request #58 from luxtella/processtitle
805a3ae 
[Tizen] Don't SetProcessTitleFromCommandLine.
@kenchris kenchris merged commit 805a3ae into crosswalk-project:master Sep 4, 2013
darktears pushed a commit that referenced this pull request Sep 29, 2014
@dzhioev
Revert of Enable forced extension updates on NaCl arch mismatch (patc…
dd6d036 
…hset #5 id:100001 of https://codereview.chromium.org/516293007/)

Reason for revert:
Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations.

Log and stack trace:
[16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend.
[16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated.
[16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7fe3122e555e base::debug::StackTrace::StackTrace()
#1 0x7fe31237c462 logging::LogMessage::~LogMessage()
#2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed()
#3 0x7fe3123630a1 base::PathExists()
#4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs()
#5 0x7fe321cfad22 extensions::Extension::InitFromValue()
#6 0x7fe321cfa490 extensions::Extension::Create()
#7 0x7fe321cfa114 extensions::Extension::Create()
#8 0x7fe3233ebe1b extensions::ComponentLoader::Load()
#9 0x7fe3233ec3cf extensions::ComponentLoader::Add()
#10 0x7fe3233ec32a extensions::ComponentLoader::Add()
#11 0x7fe3233ec2b0 extensions::ComponentLoader::Add()
#12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension()
#13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded()
#14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension()
#15 0x7fe322f68bb2 chromeos::WebUILoginView::Init()
#16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView()
#17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL()
#18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard()
#19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI()
#20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe()
#21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe()
#22 0x7fe31b222377 content::NotificationServiceImpl::Notify()
#23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished()
#24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished()
#25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted()
#26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted()
#27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive()
#28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings()
#29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating()
#30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController()
#31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows()
#32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode()
#33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage()
#34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper()
#35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest()
#36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run()
#37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo()
#38 0x7fe322fbaba5 base::internal::Invoker<>::Run()
#39 0x7fe3122cc9ce base::Callback<>::Run()
#40 0x7fe312488f86 base::Timer::RunScheduledTask()
#41 0x7fe3124890bc base::BaseTimerTaskInternal::Run()
#42 0x7fe312489382 base::internal::RunnableAdapter<>::Run()
#43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo()
#44 0x7fe312489295 base::internal::Invoker<>::Run()
#45 0x7fe3122cc9ce base::Callback<>::Run()
#46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask()
#47 0x7fe3123a1c57 base::MessageLoop::RunTask()
#48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask()
#49 0x7fe3123a228d base::MessageLoop::DoDelayedWork()
#50 0x7fe3122a1f25 base::MessagePumpGlib::Run()
#51 0x7fe3123a17f0 base::MessageLoop::RunHandler()
#52 0x7fe3124093b2 base::RunLoop::Run()
#53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun()
#54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts()
#55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run()
#56 0x7fe31ad251b1 content::BrowserMain()
#57 0x7fe31abb997f content::RunNamedProcessTypeMain()
#58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run()
#59 0x7fe31abb8ee5 content::ContentMain()
#60 0x7fe3206d3505 ChromeMain
#61 0x7fe3206d34b2 main

Cannot upload crash dump: cannot exec /sbin/crash_reporter

Crash_reporter failed to process crash report

Original issue's description:
> Enable forced extension updates on NaCl arch mismatch
>
> This makes extensions aware of the platforms for which
> they have platform-specific resources installed, if any.
>
> This also hooks up the extension update code with some
> additional logic to place an extension in forced-update
> mode if it has platform-specific resources which don't
> match the current NaCl architecture.
>
> BUG=409948
> TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=409948

Review URL: https://codereview.chromium.org/532183003

Cr-Commit-Position: refs/heads/master@{#293128}
rakuco pushed a commit that referenced this pull request Oct 10, 2014
@SenorBlanco
[Cherry-pick of http://crrev.com/297689 to M39 branch.]
c7a954a 
Chromium flag to enable accelerated YUV decoding.

BUG=413001
[email protected]

Original Review URL: https://codereview.chromium.org/605373002

Review URL: https://codereview.chromium.org/631923002

Cr-Commit-Position: refs/branch-heads/2171@{#58}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk pushed a commit that referenced this pull request Feb 10, 2015
Add UMA for TouchToFirstScrollUpdateSwap
f7ca804 
TouchToScrollUpdateSwap is currently tracked in UMA. While this is
useful for gauging the typical response time for each event in a scroll
sequence, it is insufficient to indicate the intial scroll response
time. Add a TouchToFirstScrollUpdateSwap which measures the time between
touch event creation for the first GestureScrollUpdate in a sequence and
the frame swap time caused by that first scroll event.

Also remove INPUT_EVENT_LATENCY_SCROLL_UPDATE_RWH_COMPONENT as it is no
longer used on Aura.

BUG=436965

Review URL: https://codereview.chromium.org/827963005

Cr-Commit-Position: refs/heads/master@{#311928}
(cherry picked from commit bf3a626)

Review URL: https://codereview.chromium.org/861783002

Cr-Commit-Position: refs/branch-heads/2272@{#58}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@alexelias
Blacklist GPU raster and canvas on all PowerVR SGX.
068e47b 
Unfortunately, an OEM Lollipop build on an SGX 544 shipped without
fixing the driver bug causing GPU raster to be incorrect, so
unconditionally blacklist PowerVR SGX GPUs.

BUG=461456

Review URL: https://codereview.chromium.org/949423002

Cr-Commit-Position: refs/heads/master@{#317980}
(cherry picked from commit 7c0ab50)

Review URL: https://codereview.chromium.org/967183002

Cr-Commit-Position: refs/branch-heads/2311@{#58}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 15, 2015
Merge: Stop calling InputServiceProxy::WarmUp() during browser shutdown
6cc19de 
BUG=474962

Review URL: https://codereview.chromium.org/1068163003

Cr-Commit-Position: refs/heads/master@{#324594}
(cherry picked from commit 34fc26f)

[email protected]

Review URL: https://codereview.chromium.org/1086463003

Cr-Commit-Position: refs/branch-heads/2357@{#58}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco pushed a commit that referenced this pull request Jun 8, 2015
Let Ubertoken Fetch be primed with an access token.
b2a0494 
BUG=483596
TEST=Logging in with ChromeOS still results in the user logging into the content area.
[email protected]

Review URL: https://codereview.chromium.org/1129463004

Cr-Commit-Position: refs/heads/master@{#330752}
(cherry picked from commit bf49154)

Review URL: https://codereview.chromium.org/1151103002

Cr-Commit-Position: refs/branch-heads/2403@{#58}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
@jollycopper
Fix a crash about opening a folder that was deleted by sync
59f7b67 
If a bookmark is deleted by sync, bookmarkNodeRemoved() will not be
called in EBManager.

BUG=523924

Review URL: https://codereview.chromium.org/1311873002

Cr-Commit-Position: refs/heads/master@{#345125}
[email protected]

Review URL: https://codereview.chromium.org/1317183002 .

Cr-Commit-Position: refs/branch-heads/2490@{#58}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
(Merging on behalf of mdw@)
773e3aa 
Add UMA to count the number of Google CAPTCHA pages shown and solved by users.

This is intended to track down problems where a large number of mobile
users in certain countries are apparently seeing CAPTCHA pages.
(http://b2.corp.google.com/23081866 for context.)

I realize this may not be the ideal place for this code - happy for suggestions as to where else this might go.

BUG=552470

Review URL: https://codereview.chromium.org/1441393002

Cr-Commit-Position: refs/heads/master@{#360011}
(cherry picked from commit 71c7cac)

Review URL: https://codereview.chromium.org/1465533002 .

Cr-Commit-Position: refs/branch-heads/2564@{#58}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
@dgozman
Merge to 2623 "[DevTools] Fix main menu not working."
bb29ee1 
> [DevTools] Fix main menu not working.
>
> BUG=578713
> TBR=pfeldman
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/1601853003
>
> Cr-Commit-Position: refs/heads/master@{#370177}

(cherry picked from commit 0b3e184)
TBR=pfeldman

Review URL: https://codereview.chromium.org/1617273002 .

Cr-Commit-Position: refs/branch-heads/2623@{#58}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
Revert "Expose stable_device_id in audio extension apis."
8850b24 
This reverts commit 2ae95ec.

Revert "Initialize stable_device_id for fake devices created by FakeCrasAudioClient::Init()"

This reverts commit adbc6b1.

BUG=308143
TBR=rkc

Review URL: https://codereview.chromium.org/1760083002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#58}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
@japacible
[Media Router WebUI] Show issue's secondary action when 'dismiss'.
802c756 
The action type 'dismiss' maps to 0. Currently, we don't check whether it's undefined, but if it is truthy. if(0) is always false. This means that if the secondary button is 'dismiss', it will not be shown.

This was previously not caught as the tests mark non-existent secondary actions as null rather than undefined.

BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1998013003
Cr-Commit-Position: refs/heads/master@{#395394}
(cherry picked from commit 8d0894e)

Review URL: https://codereview.chromium.org/2014673002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#58}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
Incrementing VERSION to 62.0.3202.12
c05a6ca 
[email protected]

Change-Id: Ief163a0110c056916292a0a1f505fecd7cd0cb23
Reviewed-on: https://chromium-review.googlesource.com/654319
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#58}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-hwang @kenchris