This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Optimize FrameRateController to manually tick when FPS < 60 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cameo uses Chromium resource framework (grit/grd). To make sure Cameo resource IDs are unique cross Chromium components, it is required to add new starting resource IDs. Since Cameo is a project built on Chromium, allocate starting IDs from 31000.
> [Android] Always set "mobile user agent" switch to the right vlaue when launching the browser process. > > This fixes the user agent for the browser process when the browser process has been started by an activity other than Main, like sync, bookmark provider, etc. If > chrome is started as a background process, the switch is never added. Since the > user agent is computed early on during start-up and not recomputed (from users > of content::GetUserAgent) this can lead to incorrect UA being reported and > broken results. > > We probably shouldn't do it this way long-term but this is a minimal fix for m27. > > NOTRY=true > BUG=237471 > > Review URL: https://chromiumcodereview.appspot.com/14682021 [email protected] Review URL: https://codereview.chromium.org/14671011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199829 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Use a sysroot for Chrome Linux official builds. (try 2) > > BUG=224487 > [email protected] > > Review URL: https://codereview.chromium.org/15030002 [email protected] Review URL: https://codereview.chromium.org/14932012 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199841 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Convert build/linux/install-debian.wheezy.sysroot.wrapper.sh to python for Windows compatibility. > > BUG=224487 > TBR=dbeam > > Review URL: https://codereview.chromium.org/15059002 [email protected] Review URL: https://codereview.chromium.org/15143004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199842 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@199853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Disable Drive API v2 for M-28 release. > > Unfortunately it turned out that the files.search method of Drive API v2 > sometimes un-acceptablly slow. So, this CL temporarily disables Drive API v2 > and moves back to GData WAPI, until the problem is solved. > > BUG=239729 > TEST=Ran unit_tests and try bots > > Review URL: https://chromiumcodereview.appspot.com/14858024 [email protected] Review URL: https://codereview.chromium.org/14991005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199884 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Revert r196089 "Add default values for Latin script font prefs." > > Reverting because it caused bug 237258. Many sites set lang="en" > which cause the Latin font prefs to be used, and it's surprising > to users that chrome://settings/fonts is not respected. We need > a more obvious way to customize per-script fonts first. > > BUG=237258 > TBR=bauerb > > Review URL: https://chromiumcodereview.appspot.com/14877009 [email protected] Review URL: https://codereview.chromium.org/14667011 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Move post-signin confirmation bubble to OneClickSigninSyncStarter. > > OneClickSigninSyncStarter now displays the post-signin confirmation bubble so > we can better integrate this with the rest of the signin UI (creating a new > profile, displaying the SAML dialog, etc). > > BUG=174655,232339,236828,238173 > [email protected] > > Review URL: https://codereview.chromium.org/14914003 [email protected] Review URL: https://codereview.chromium.org/14667012 git-svn-id: http://src.chromium.org/svn/branches/1500/src@199943 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@200010 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixes a typo: disabled_extension_ids_ should not be cleared here. > > BUG=238525 > [email protected], > > Review URL: https://chromiumcodereview.appspot.com/14963006 [email protected] Review URL: https://codereview.chromium.org/14566018 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200011 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Changes the order of widget Close() and DecrementDeferCounter(). > > This is a bit tricky scenario, but the current code may lead to > a mismatch of increment/decrement by calling Close(). See the bug > for how the mismatch happens. > > BUG=238477 > > Review URL: https://chromiumcodereview.appspot.com/14820016 [email protected] Review URL: https://codereview.chromium.org/15019018 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200013 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixes a crash bug of calling animator without check. > > BUG=239508 > [email protected] > > Review URL: https://chromiumcodereview.appspot.com/14991004 [email protected] Review URL: https://codereview.chromium.org/15019019 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200014 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> PPAPI: Check for NULL dispatcher in PPP_VideoDecoder > > Please see the bug for details. > > BUG=238373 > > Review URL: https://chromiumcodereview.appspot.com/15039003 [email protected] Review URL: https://codereview.chromium.org/14772034 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200018 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Make cloud print dialog work with cloud printer on first signin. > Better check for current URL. > Assign data only to cloud print URLs. > Don't reset data_. > > BUG=236786 > > Review URL: https://chromiumcodereview.appspot.com/14864005 [email protected] Review URL: https://codereview.chromium.org/14850020 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200057 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Regression issue with "ShouldHop", the UpdateState->Layout flow was updated during M-27 to resolve a similar issue due to Updates that didn't change bounds not flowing into Layout, however due to some merging/partial reverts, this flow got partially reverted regressing these bugs. > > BUG=234655 > [email protected] > > Review URL: https://codereview.chromium.org/14640019 [email protected] Review URL: https://codereview.chromium.org/15174004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200065 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fix imageburner trying to extract downloaded image to unexisting folder. > > BUG=239330 > TEST=burned recovery image using chrome://imageburner > > Review URL: https://chromiumcodereview.appspot.com/14773024 [email protected] Review URL: https://codereview.chromium.org/14974008 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Base: Disable the scoped handle verifier. > > This is intended for the M28 beta branch. > > BUG=240766 > TEST=none > [email protected] > > Review URL: https://codereview.chromium.org/14979005 [email protected] Review URL: https://codereview.chromium.org/14657026 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200077 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
git-svn-id: http://src.chromium.org/svn/branches/1500/src@200112 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Use the correct output index to get state for outputs. > > BUG=239412 > TEST=manual. see bug for repro step. > > Review URL: https://chromiumcodereview.appspot.com/14699004 [email protected] Review URL: https://codereview.chromium.org/14731026 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200145 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Removed reference to whitelisting requirement. > > BUG= > [email protected], [email protected] > > Review URL: https://codereview.chromium.org/14909003 [email protected] Review URL: https://codereview.chromium.org/14676013 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200164 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Session restore: fix a crash when the "crashed" infobar changed browsers. > > The info bar used to store a pointer to the Browser it was associated with when > it was created. But the browser can change if the tab with the info bar is > dragged away, and the original browser can be destroyed. > > BUG=236490 > > Review URL: https://chromiumcodereview.appspot.com/14893005 [email protected] Review URL: https://codereview.chromium.org/14972018 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200169 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fix ChromeOS crash due to NULL browser > > r197272 caused a crash in the ChromeOS login UI. Fix was to check for a NULL browser_. > > BUG=237214 > [email protected] > > Review URL: https://codereview.chromium.org/14631009 [email protected] Review URL: https://codereview.chromium.org/14706008 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200171 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Making component extension ime as first input method. > > The first input method is determined by some rule from available input method. > However Component extension IME is not initialize synchronously at the begging of bootstrap, so they are not available when the GetFirstLogingINputMethodIds is called. > > BUG=239372 > TEST=Manually done on my lumpy. > > Review URL: https://chromiumcodereview.appspot.com/14883007 [email protected] Review URL: https://codereview.chromium.org/14629022 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200172 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> CrOS Files.app: Hide the middle bar by default on initialize. > > This patch hides the middle panel and the splitter at the initialization time. This prevets the middle bar glitch (see crbug.com/239155) when the default directory is on non-drive volume. > > Even if the default directory is Drive, the new glitch is not happened by this patch. The middle bar will appear at the same timing as the list updated. > > BUG=239155 > TEST=manual > > NOTRY=True > # NOTRYing for chromeos_linux already passes > > Review URL: https://chromiumcodereview.appspot.com/14870005 [email protected] Review URL: https://codereview.chromium.org/15050005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> CrOS Files.app: Restyle breadcrumb list and show it on normal directory. > > This patch changes around preview panel to match the spec in the new UI. > - Restyle breadcrumb list CSS to match the spec > - Make the preview panel 1 line (previously 2 lines). Show breadcrumb if zero or one file is selected. Otherwise, show the sum of the selected files. > - Show the search breadlcrumb all directory except root directories (hence, the breadlcrumb is no longer "search" breadlcrumb). > > This patch shouldn't effect any change to the previous ui. > > BUG=238702 > TEST=manual > [email protected] > > Review URL: https://codereview.chromium.org/14829009 [email protected] Review URL: https://codereview.chromium.org/15185004 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200174 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Avoid reopening windows when closing and opening a lid while using a usb stick. > > After migrating to Files.app V2, reusing tabs stopped working, since a platform app's windows are not browser windows. Therefore, iterating over browser windows for finding a tab with the same url was always failing. As a resul, the new window was always being recreated. This patch fixes this problem by moving the reusing/creating decision logic to background.js, which is responsible for creating Files.app's windows. > The new logic for Files.app V2 is as follows. > - For ALWAYS_CREATE: create a new Files.app's window, even if there are other. > - For FOCUS_ANY_OR_CREATE: if there is a window with the same path, focus it. If not, then focus any other window if none is focused yet. If there are no windows, then create. > - For FOCUS_SAME_OR_CREATE: if there is a window with the same path, focus it. If not, then create. > > TEST=Tested manually. Follow the bug's repro steps. > BUG=239833 > [email protected], [email protected] > > Review URL: https://codereview.chromium.org/14807008 [email protected] Review URL: https://codereview.chromium.org/15117005 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200179 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Fixed dialog buttons in the Files.app's photo editor. > > The problem with buttons occured because of conflict of css selectors for gallery's buttons and the dialog, which are completely different. This patch addresses this issue by adding a .toolbar and .header context to the button's selectors so they do not affect general button styles. > > TEST=Open a photo in Files.app, try to delete. > BUG=240402 > > Review URL: https://chromiumcodereview.appspot.com/15149003 [email protected] Review URL: https://codereview.chromium.org/15147003 git-svn-id: http://src.chromium.org/svn/branches/1500/src@200180 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Remove invalid resources file entry from chromium resource_ids
Create GPU process object before creating GPU thread in single process
| @@ -9,6 +9,17 @@ | |||
| #include "cc/base/thread.h" | |||
| #include "cc/scheduler/delay_based_time_source.h" | |||
| #include "cc/scheduler/time_source.h" | |||
| #include "cc/trees/layer_tree_host_impl.h" | |||
| #include "cc/debug/frame_rate_counter.h" | |||
|
thanks for the patch, really helpful for us. 👍 |
Trybot DashboardBuilding status:Finished the build of the PATCH in this pull requestThu Aug 29 2013 17:58:32 GMT+0800 (CST) [content_linux] Failed LOGS: failed update Rebuild the failed bots you want!Select the bots:
Start the building:
|
|
Hi, yongsheng and shouqun. Thanks for your comments. All suggestions has been done in the new commit. PTAL. |
|
@huningxin, please have a review as well. |
|
@darktears , the two commits are against old version of Crosswalk and are not in upstream. I have another different patch for Crosswalk based on Chromium 29.0.1547.57 and it can bring the same performance improvement on Canvas2D/WebGL. It can be applied to latest Upstream code as well. Chromium guys from Google have some big and complex plan on improving this as well. I will contact them for some feedback. |
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}
rakuco
pushed a commit
that referenced
this pull request
Oct 10, 2014
This is a smaller library that is always checked out and depsed in. It seems there is no particular reason for it to be in a separate repo other than it makes changes more difficult. Review URL: https://codereview.chromium.org/608853002 Cr-Commit-Position: refs/heads/master@{#297781} (cherry picked from commit ef5e3c5) BUG= Review URL: https://codereview.chromium.org/629223002 Cr-Commit-Position: refs/branch-heads/2171@{#52} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk
pushed a commit
that referenced
this pull request
Feb 10, 2015
Fixes the DomCode -> KeyboardCode conversion for DomCode::BROWSER_BACK. BUG=449741 TEST=Manual, see bug TBR=pkotwicz Review URL: https://codereview.chromium.org/820073008 Cr-Commit-Position: refs/branch-heads/2272@{#52} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
… app users. If a user has auto-import enabled in the g+ photos app, don't enable cloud import, and don't pop up notifications for it yet. We'll re-enable these notifications when the transition path has been smoothed a bit more. BUG=462110 Review URL: https://codereview.chromium.org/955313002 Cr-Commit-Position: refs/heads/master@{#318237} (cherry picked from commit 56c9dc7) Files.app: Fix a bug where messages from G+ photos app aren't properly handled. Fix test.util.registerRemoteTestUtils so external messages get propagated to all listeners. Fix notification callback code to open files app in the right location when an import is initiated from a notification click. BUG=459359 Review URL: https://codereview.chromium.org/959493004 Cr-Commit-Position: refs/heads/master@{#317987} (cherry picked from commit 169cabf) TBR=mtomasz Review URL: https://codereview.chromium.org/965003002 Cr-Commit-Position: refs/branch-heads/2311@{#52} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 15, 2015
A UserImageRequest can complete after the last reference to UserImageLoader is gone. Fix by holding a reference to UserImageLoader in UserImageRequest instead of just a pointer. BUG=474970 Review URL: https://codereview.chromium.org/1078573002 Cr-Commit-Position: refs/heads/master@{#324507} (cherry picked from commit 476d53d) [email protected] Review URL: https://codereview.chromium.org/1082613003 Cr-Commit-Position: refs/branch-heads/2357@{#52} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Jun 8, 2015
This restores the ability for the prefixed EME API to use secure codecs when the renderer preference is set. BUG=489512 Review URL: https://codereview.chromium.org/1132323004 Cr-Commit-Position: refs/heads/master@{#330642} (cherry picked from commit 05df568) [email protected] Review URL: https://codereview.chromium.org/1149973005 Cr-Commit-Position: refs/branch-heads/2403@{#52} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
The generic bell icon is deemed to be confusing, as it creates an association with alarms rather than generic notifications. Use the Chrome icon instead. NOTRY=true NOPRESUBMIT=true TBR=pennymac BUG=523990 Review URL: https://codereview.chromium.org/1313593003 Cr-Commit-Position: refs/heads/master@{#345589} (cherry picked from commit 1598c3b) Review URL: https://codereview.chromium.org/1312433007 Cr-Commit-Position: refs/branch-heads/2490@{#52} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Treat dictionary-based permissions separately from the standard string-based permissions. Also drop the "sockets" (note the trailing "s") permission because that is a manifest entry, not a permission entry. Also minor logging improvements. BUG=578143 TEST=unit tests added Review URL: https://codereview.chromium.org/1587253004 Cr-Commit-Position: refs/heads/master@{#370032} (cherry picked from commit d8497f8) Review URL: https://codereview.chromium.org/1617133002 . Cr-Commit-Position: refs/branch-heads/2623@{#52} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
…t main frame Layout"" This reverts commit 2441792. Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#52} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#52}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
…mode) Recently offline pages was changed to be completely disabled in incognito profiles, since it is no longer associated with bookmarks, so some consumers failed to check for null. BUG=613359 Review-Url: https://codereview.chromium.org/2004473002 Cr-Commit-Position: refs/heads/master@{#395422} (cherry picked from commit 261c816) Review URL: https://codereview.chromium.org/2007113007 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#52} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Commit minimal migration status to local state PrefService. Introduces a CommitPendingWrite function with a callback to be sure that prefs landed on disk. BUG=747907 [email protected] (cherry picked from commit e1f238f) Change-Id: I565ffbae7b8a1e934875101012c39c8a9841a139 Reviewed-on: https://chromium-review.googlesource.com/647454 Reviewed-by: Xiyuan Xia <[email protected]> Reviewed-by: Bernhard Bauer <[email protected]> Commit-Queue: Pavol Marko <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499693} Reviewed-on: https://chromium-review.googlesource.com/653639 Reviewed-by: Pavol Marko <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#52} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deals with performance gap between Crosswalk and SWE browser on WebGL/Canvas, etc.
Some details can be found at https://github.com/otcshare/crosswalk-internal/wiki/FrameRateController-and-its-impact-on-performance.
For http://rscohn2.herokuapp.com/sbp/, on IA phone(ZTE V975), the FPS for Canvas2D increases from 33 to 54 and for WebGL increases from 54 to 59; On Nexus 4, the FPS for Canvas2D increases from 32 to 53 and for WebGL increases from 35 to 57.