This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Fix the issue of ContentShell can't play video with file scheme. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaInfoLoader checks single security origin and CROS access, but for media resources with file protocol, it always returns false, which disables local video playback. BUG=234710 TEST=video with file protocol Review URL: https://chromiumcodereview.appspot.com/19324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211967 0039d316-1c4b-4281-b951-d872f2087c98
|
@kenchris @darktears PTAL, thanks We need this patch to be merged, it's already in upstream (https://codereview.chromium.org/19324002), but not in Chrome 29 |
Trybot DashboardBuilding status:Finished the build of the PATCH in this pull requestFri Aug 30 2013 14:10:00 GMT+0800 (CST) [content_linux] Failed LOGS: failed update Rebuild the failed bots you want!Select the bots:
Start the building:
|
|
Please put the link of the upstream patch in the commit message. It will ease future rebasing. |
|
It's already there: See https://chromiumcodereview.appspot.com/19324002 |
darktears
added a commit
that referenced
this pull request
Aug 30, 2013
[Android] Fix the issue of ContentShell can't play video with file scheme.
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}
rakuco
pushed a commit
that referenced
this pull request
Oct 10, 2014
…oop. This will make the first tab go to the: - Switch Person button for signed in profiles - the authentication error button for signed in profiles with an error - the "sign in" button for local profiles BUG=414794 [email protected] Review URL: https://codereview.chromium.org/605323002 Cr-Commit-Position: refs/heads/master@{#297561} (cherry picked from commit df6e287) Review URL: https://codereview.chromium.org/629233002 Cr-Commit-Position: refs/branch-heads/2171@{#53} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
…oded. Eliminates a bug where files will spaces in name were not being marked as synced. Also: 1) Remove an unused method (with a TODO body) in ImportTask. BUG=461174 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/954943006 Cr-Commit-Position: refs/heads/master@{#318197} (cherry picked from commit 4cf03c7) Files.app: Fix js exceptions in table rendering. The status column isn't always visible. Account for that when attempting to update table elements. BUG=461723 Review URL: https://codereview.chromium.org/952893008 Cr-Commit-Position: refs/heads/master@{#318060} (cherry picked from commit 4e9ddaa) TBR=mtomasz Review URL: https://codereview.chromium.org/961403002 Cr-Commit-Position: refs/branch-heads/2311@{#53} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Jun 8, 2015
…ooth Low Energy devices." Original issue's description: > Implementing a proximity_auth::Connection interface for Bluetooth Low Energy > devices. > > The current version does not handle messages larger than a single characteristic > size (around 150 bytes). Message receiving functionality is not implemented yet. > > BUG=485123 > Committed: https://crrev.com/574c1637312ef98f8fa4bde909c1f040ddf33a4b > Cr-Commit-Position: refs/heads/master@{#329837} BUG=490635 [email protected], [email protected] Review URL: https://codereview.chromium.org/1150033003 Cr-Commit-Position: refs/branch-heads/2403@{#53} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
Overrides the tabwebcontentdelegate calls that assumes the presence of a tabcreator which is not there for custom tabs. Loads the targetUrl on the same page instead. BUG=524562 Review URL: https://codereview.chromium.org/1308563006 Cr-Commit-Position: refs/heads/master@{#345525} [email protected] Review URL: https://codereview.chromium.org/1318983003 . Cr-Commit-Position: refs/branch-heads/2490@{#53} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
The current code expect that DEFAULT is -1 instead of 0. Thus, the permission is never actually reset and the NOTREACHED is hit on Debug builds. This CL tries to do the ContentSetting -> jint / jint -> ContentSetting conversions as close to the JNI layer as possible to prevent further confusions. BUG=554838 [email protected] Review URL: https://codereview.chromium.org/1439933002 Cr-Commit-Position: refs/heads/master@{#359763} (cherry picked from commit c717aee) Review URL: https://codereview.chromium.org/1460483004 . Cr-Commit-Position: refs/branch-heads/2564@{#53} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=510817 Review URL: https://codereview.chromium.org/1590193005 Cr-Commit-Position: refs/heads/master@{#369945} (cherry picked from commit a7098af) Review URL: https://codereview.chromium.org/1613333002 . Cr-Commit-Position: refs/branch-heads/2623@{#53} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
mrunalk
pushed a commit
that referenced
this pull request
Apr 29, 2016
BUG=601001 [email protected] Review URL: https://codereview.chromium.org/1879453004 . Cr-Commit-Position: refs/heads/master@{#386590} Review URL: https://codereview.chromium.org/1892463002 . Cr-Commit-Position: refs/branch-heads/2704@{#53} Cr-Branched-From: 6e53600-refs/heads/master@{#386251} Review URL: https://codereview.chromium.org/1893603004 . Cr-Commit-Position: refs/branch-heads/2661@{#590} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
…ayoutIfNeededRecursive() This will help us to know if the failure of later RELEASE_ASSERT( !needsLayout()) is because the layout fails to clear the flag, or needsLayout is set after layout and before the later assert. BUG=590856,545039 [email protected] Review URL: https://codereview.chromium.org/1755893002 . (cherry picked from commit 69310ab) Cr-Original-Commit-Position: refs/heads/master@{#378698} Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#53} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#53}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
On Android JB, TextView#onSaveInstanceState() calls new SpannableString() which causes a crash. The reason is that SpannableStringInternal#setSpan() eventually calls ChangeWatcher#onSpanChanged() and this causes onSelectionChanged(). However, the selection values remain the same, so we can simply ignore the call when the values did not change. BUG=760013 (cherry picked from commit acfc998) Change-Id: I907afd43dae36513b8015572a5568060d8b545b3 Reviewed-on: https://chromium-review.googlesource.com/644495 Commit-Queue: Changwan Ryu <[email protected]> Reviewed-by: Ted Choc <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499100} Reviewed-on: https://chromium-review.googlesource.com/653211 Reviewed-by: Changwan Ryu <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#53} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaInfoLoader checks single security origin and CROS access, but for media
resources with file protocol, it always returns false, which disables local
video playback.