Skip to content

Commit

Permalink
Revert 263352 "Introduce RenderFrameProxyHost object and use it ..."
Browse files Browse the repository at this point in the history
Leaks: Linux LSan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1508

E.g.:
Indirect leak of 1544 byte(s) in 1 object(s) allocated from:
    #0 0x4fc78b in operator new(unsigned long) /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x232ebeb in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92
    #2 0x232ebeb in _M_allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:150
    #3 0x232ebeb in _M_allocate_and_copy<std::move_iterator<__gnu_cxx::_Hashtable_node<std::pair<const std::basic_string<char>, content::SiteInstance *> > **> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:1052
    #4 0x232ebeb in reserve /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/vector.tcc:74
    crosswalk-project#5 0x232ebeb in _M_initialize_buckets /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:577
    crosswalk-project#6 0x232ebeb in __gnu_cxx::hashtable<std::pair<std::string const, content::SiteInstance*>, std::string, __gnu_cxx::hash<std::string>, std::_Select1st<std::pair<std::string const, content::SiteInstance*> >, std::equal_to<std::string>, std::allocator<content::SiteInstance*> >::hashtable(unsigned long, __gnu_cxx::hash<std::string> const&, std::equal_to<std::string> const&, std::allocator<std::pair<std::string const, content::SiteInstance*> > const&) /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:334
    crosswalk-project#7 0x232cb58 in RefCounted /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/hash_map:126
    crosswalk-project#8 0x232cb58 in content::BrowsingInstance::BrowsingInstance(content::BrowserContext*) content/browser/browsing_instance.cc:18
    crosswalk-project#9 0x28d4131 in content::SiteInstance::Create(content::BrowserContext*) content/browser/site_instance_impl.cc:220
    crosswalk-project#10 0x2db9c92 in CreateTestWebContents content/public/test/test_renderer_host.cc:138
    crosswalk-project#11 0x2db9c92 in content::RenderViewHostTestHarness::SetUp() content/public/test/test_renderer_host.cc:182
    crosswalk-project#12 0xda5e2d in content::RenderFrameHostManagerTest::SetUp() content/browser/frame_host/render_frame_host_manager_unittest.cc:204
    crosswalk-project#13 0x2eea0f2 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
    crosswalk-project#14 0x2eea0f2 in testing::Test::Run() testing/gtest/src/gtest.cc:2057
    crosswalk-project#15 0x2eec3a9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    crosswalk-project#16 0x2eed183 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    crosswalk-project#17 0x2efe463 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    crosswalk-project#18 0x2efda30 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    crosswalk-project#19 0x2efda30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    crosswalk-project#20 0x2e7712c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    crosswalk-project#21 0x2e7712c in base::TestSuite::Run() base/test/test_suite.cc:213
    crosswalk-project#22 0x2e6aebd in Run base/callback.h:401
    crosswalk-project#23 0x2e6aebd in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback<int ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    crosswalk-project#24 0x1bfec66 in main content/test/run_all_unittests.cc:14
    crosswalk-project#25 0x7f853fc5876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

> Introduce RenderFrameProxyHost object and use it in RFHM.
> 
> This is the first CL in a series to create RenderFrameProxy(Host) infrastructure. Before the Blink codebase is ready to transform local and remote frames, the proxy objects will keep internally the existing RF/RFH in swapped out state. This CL creates the browser side proxy object and wraps the swapped out RFH.
> 
> BUG=357747
> 
> Review URL: https://codereview.chromium.org/217163007

[email protected]

Review URL: https://codereview.chromium.org/236003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263367 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed Apr 11, 2014
1 parent 2c4d732 commit c9b4bff
Show file tree
Hide file tree
Showing 6 changed files with 136 additions and 335 deletions.
Loading

0 comments on commit c9b4bff

Please sign in to comment.