Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Revert of Add VideoFrameRecorder for use recording test frame sequenc…
Browse files Browse the repository at this point in the history
…es. (https://codereview.chromium.org/339073002/)

Reason for revert:
Brand new test fails in ASAN:

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x462ccb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
#1 0x7ee8f9 in CreateNextFrame remoting/host/video_frame_recorder_unittest.cc:96
#2 0x7ee8f9 in remoting::VideoFrameRecorderTest::CreateTestFrames() remoting/host/video_frame_recorder_unittest.cc:112
#3 0x7f1184 in remoting::VideoFrameRecorderTest_EncodeButDontRecord_Test::TestBody() remoting/host/video_frame_recorder_unittest.cc:269
#4 0xb3bf38 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
#5 0xb3bf38 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#6 0xb3e1c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#7 0xb3ef56 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#8 0xb5206a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#9 0xb516a0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#10 0xb516a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#11 0xab66bc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#12 0xab66bc in base::TestSuite::Run() base/test/test_suite.cc:227
#13 0xaada32 in Run base/callback.h:401
#14 0xaada32 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
#15 0xaad3ad in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553
#16 0x4e8067 in main chrome/test/base/run_all_remoting_unittests.cc:31
#17 0x7f1f660df76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


Original issue's description:
> Add VideoFrameRecorder for use recording test frame sequences.
> 
> This will be used to record representative frame sequences for performance evaluation of the new VP9 encoder.
> 
> BUG=260879
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279795

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=260879

Review URL: https://codereview.chromium.org/350903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279805 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed Jun 25, 2014
1 parent d27f1e2 commit d0fe478
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 589 deletions.
207 changes: 0 additions & 207 deletions remoting/host/video_frame_recorder.cc

This file was deleted.

100 changes: 0 additions & 100 deletions remoting/host/video_frame_recorder.h

This file was deleted.

Loading

0 comments on commit d0fe478

Please sign in to comment.