Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Revert 280400 "Creation of a new and improved object for the cac..."
Browse files Browse the repository at this point in the history
Seems to have introduced leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3527/steps/net_unittests/logs/stdio

For example:

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x5166cb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
#1 0x16ce6be in MockDiskCache::CreateEntry(std::string const&, disk_cache::Entry**, base::Callback<void (int)> const&) net/http/mock_http_cache.cc:408
#2 0x37654a7 in DoCreate net/http/disk_based_cert_cache.cc:187
#3 0x37654a7 in net::DiskBasedCertCache::WriteWorker::DoLoop(int) net/http/disk_based_cert_cache.cc:158
#4 0x3768f23 in Start net/http/disk_based_cert_cache.cc:125
#5 0x3768f23 in net::DiskBasedCertCache::Set(CERTCertificateStr*, base::Callback<void (std::string const&)> const&) net/http/disk_based_cert_cache.cc:533
#6 0x10d0ffa in net::DiskBasedCertCache_SyncSet_Test::TestBody() net/http/disk_based_cert_cache_unittest.cc:231
#7 0x33ce728 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
#8 0x33ce728 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#9 0x33d0f09 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#10 0x33d1c96 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#11 0x33e4daa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#12 0x33e43e0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#13 0x33e43e0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#14 0x40a6d1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#15 0x40a6d1c in base::TestSuite::Run() base/test/test_suite.cc:227
#16 0x409b4e2 in Run base/callback.h:401
#17 0x409b4e2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
#18 0x409ae5d in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553
#19 0x2b986cc in main net/test/run_all_unittests.cc:64
#20 0x7fc4683a976c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


> Creation of a new and improved object for the caching of certificate objects on disk.
> 
> Review URL: https://codereview.chromium.org/329733002

[email protected]

Review URL: https://codereview.chromium.org/349533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280492 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed Jun 28, 2014
1 parent 2d0749f commit ccf2515
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 1,100 deletions.
Loading

0 comments on commit ccf2515

Please sign in to comment.