Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Revert of Chrome power profiler service (https://codereview.chromium.…
Browse files Browse the repository at this point in the history
…org/140583003/)

Reason for revert:
Appears to have caused a memory leak.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService

Indirect leak of 176 byte(s) in 1 object(s) allocated from:
    #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
    #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85
    #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138
    #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213
    #12 0x2cb4041 in Run base/callback.h:401
    #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x195d8ce in main content/test/run_all_unittests.cc:14
    #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


Original issue's description:
> This CL implemented part of chrome power profiler, including the service, data provider and observer base.
> 
> BUG=337138
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=337138

Review URL: https://codereview.chromium.org/184583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254146 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed Feb 28, 2014
1 parent 7921fcf commit 05e70d3
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 592 deletions.
72 changes: 0 additions & 72 deletions content/browser/devtools/devtools_power_handler.cc

This file was deleted.

36 changes: 0 additions & 36 deletions content/browser/devtools/devtools_power_handler.h

This file was deleted.

31 changes: 0 additions & 31 deletions content/browser/power_profiler/power_data_provider.h

This file was deleted.

13 changes: 0 additions & 13 deletions content/browser/power_profiler/power_data_provider_dummy.cc

This file was deleted.

17 changes: 0 additions & 17 deletions content/browser/power_profiler/power_event.cc

This file was deleted.

42 changes: 0 additions & 42 deletions content/browser/power_profiler/power_event.h

This file was deleted.

33 changes: 0 additions & 33 deletions content/browser/power_profiler/power_profiler_observer.h

This file was deleted.

118 changes: 0 additions & 118 deletions content/browser/power_profiler/power_profiler_service.cc

This file was deleted.

Loading

0 comments on commit 05e70d3

Please sign in to comment.