Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API includes internal functions #24966

Closed
ghost opened this issue Jun 14, 2018 · 3 comments
Closed

API includes internal functions #24966

ghost opened this issue Jun 14, 2018 · 3 comments
Assignees
@weswigham
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Milestone
TypeScript 3.0.1

Comments

@ghost
Copy link

ghost commented Jun 14, 2018 •
edited by ghost
Loading

https://github.com/Microsoft/TypeScript/blob/a56b272d3891916a8debe36087fe7563bbade164/tests/baselines/reference/api/tsserverlibrary.d.ts#L10612 currently includes function getParentNodeInSpan, but in src/services/utilities.ts, that function appears in an /* @internal */ namespace, so it shouldn't appear in the API. (There hasn't been a publish yet this week so I don't know if it would appear in the published API.)

I checked in the commit before #24850 (c34a6d9) and the function was not present then. The file was also only 8604 lines, while now it has 14161 lines. CC @RyanCavanaugh
@ghost ghost added Infrastructure Issue relates to TypeScript team infrastructure Bug A bug in TypeScript labels Jun 14, 2018
@weswigham
Copy link
Member

@Andy-MS AFAIK @RyanCavanaugh is aware of the problem and has a fix in #24938.

@sandersn sandersn mentioned this issue Jun 14, 2018
Merged
ghost pushed a commit that referenced this issue Jun 14, 2018
Update API baselines (#24966)
5b2300c
@ghost ghost mentioned this issue Jun 14, 2018
Merged
ghost pushed a commit that referenced this issue Jun 14, 2018
moveToNewFile: Reuse code from importFixes for inserting import (#24957)
4a7a550 
* moveToNewFile: Reuse code from importFixes for inserting import

* Fix test failures

* Update API baselines (#24966)
@Kingwl Kingwl mentioned this issue Jun 14, 2018
Closed
ghost pushed a commit that referenced this issue Jun 15, 2018
Update API (#24966)
65b441f
ghost pushed a commit that referenced this issue Jun 16, 2018
Update API (#24966)
8cae586
ghost pushed a commit that referenced this issue Jun 16, 2018
Update API (#24966)
f451235
ghost pushed a commit that referenced this issue Jun 16, 2018
Update API (#24966)
248a0ae
ghost pushed a commit that referenced this issue Jun 18, 2018
Update API (#24966)
35da4ae
ghost pushed a commit that referenced this issue Jun 18, 2018
Update API (#24966)
eaa892c
ghost pushed a commit that referenced this issue Jun 18, 2018
Update API (#24966)
248da74
ghost pushed a commit that referenced this issue Jun 19, 2018
Update API (#24966)
ae7e48a
ghost pushed a commit that referenced this issue Jun 19, 2018
Undo API changes (#24966)
8eedd34
ghost pushed a commit that referenced this issue Jun 19, 2018
refactorConvertToGetAccessAndSetAccess: Don't trigger on leading triv…
7f553f4 
…ia (#25054)

* refactorConvertToGetAccessAndSetAccess: Don't trigger on leading trivia

* Update API (#24966)
ghost pushed a commit that referenced this issue Jun 19, 2018
Update API (#24966)
83e2a2c
ghost pushed a commit that referenced this issue Jun 21, 2018
Update API (#24966)
7490baf
ghost pushed a commit that referenced this issue Jun 21, 2018
Don't recommend to install '@types/foo' if that already exists (#24815)
2b9166b 
* Don't recommend to install '@types/foo' if that already exists

* Add different extra diagnostic text if the @types package exists

* Update API (#24966)
ghost pushed a commit that referenced this issue Jun 22, 2018
Update API (#24966)
0304b54
ghost pushed a commit that referenced this issue Jun 22, 2018
Update API (#24966)
7a837f4
ghost pushed a commit that referenced this issue Jun 23, 2018
Update API (#24966)
80fd3a3
ghost pushed a commit that referenced this issue Jun 25, 2018
Remove unused function (#25138)
be5986b 
* Remove unused function

* Update API (#24966)
ghost pushed a commit that referenced this issue Jun 25, 2018
Add refactor to convert named to default export and back (#24878)
806a661 
* Add refactor to convert named to default export and back

* Support ambient module

* Handle declaration kinds that can't be default-exported

* Update API (#24966)
ghost pushed a commit that referenced this issue Jun 25, 2018
Make GetEditsForFileRenameRequestArgs not extend FileRequestArgs (#25052
878bf80 
)

* Make GetEditsForFileRenameRequestArgs not extend FileRequestArgs

* Code review: check new location first, and use scriptInfo.getDefaultProject()

* Remove changes to e getDefaultProjectForFile (now #25060)

* Undo API changes (#24966)

* Combine edits from all projects (fixes #25052)

* Update API (#24966)

* Ignore orphan projects or projects with language service disabled
@ghost ghost mentioned this issue Jun 25, 2018
Merged
ghost pushed a commit that referenced this issue Jun 26, 2018
Update API (#24966)
e34875b
ghost pushed a commit that referenced this issue Jun 28, 2018
Update API (#24966)
5166631
@ghost ghost mentioned this issue Jun 28, 2018
Merged
ghost pushed a commit that referenced this issue Jun 30, 2018
Update API (#24966)
18ae354
ghost pushed a commit that referenced this issue Jun 30, 2018
Update API (#24966)
856ebe8
ghost pushed a commit that referenced this issue Jun 30, 2018
Update API (#24966)
58a7816
ghost pushed a commit that referenced this issue Jun 30, 2018
ChangeTracker: Combine deleteDeclaration, deleteNode, and deleteNodeI…
ded4465 
…nList (#25276)

* ChangeTracker: Combine deleteDeclaration, deleteNode, and deleteNodeInList

* Change name

* Update API (#24966)
ghost pushed a commit that referenced this issue Jun 30, 2018
Use helper functions in a few more places (#21308)
a1746d4 
* Use helper functions in a few more places

* Fix typo

* Update API (#24966)
ghost pushed a commit that referenced this issue Jul 2, 2018
Update API (#24966)
911658b
ghost pushed a commit that referenced this issue Jul 3, 2018
More thoroughly test navigateTo (#25239)
efc1b7d 
* More thoroughly test navigateTo

* Fix #25233 and #25237

* Update API (#24966)
ghost pushed a commit that referenced this issue Jul 3, 2018
Update API (#24966)
db03a99
ghost pushed a commit that referenced this issue Jul 3, 2018
Canonicalize path before calling startsWith (#25364)
304d45d 
* Canonicalize path before calling `startsWith`

* More specific type for sourceDirectory, and add fourslash test

* Update API (#24966)
ghost pushed a commit that referenced this issue Jul 3, 2018
Update API (#24966)
9984aeb
ghost pushed a commit that referenced this issue Jul 4, 2018
Don't add completions from a discriminated union type when the discri…
204b70d 
…minant doesn't match (#24770)

* Don't add completions from a discriminated union type when the discriminant doesn't match

* Move code to checker

* Update API (#24966)

* Use isTypeIdenticalTo
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jul 5, 2018
@mhegazy mhegazy mentioned this issue Jul 5, 2018
Closed
ghost pushed a commit that referenced this issue Jul 5, 2018
Update API (#24966)
ae945d9
ghost pushed a commit that referenced this issue Jul 5, 2018
navigateTo: Collect results from all referenced projects. (#25283)
64555aa 
* navigateTo: Collect results from all referenced projects.

* Don't use project references, just source maps

* Move more code to session

* Test when implementation file is deleted

* Use tsserver tests instead of fourslash tests to ensure session is used

* Support find-all-references

* Restore fourslash tests

* Update emit baselines (added missing newline)

* Support rename

* @weswigham code review

* Don't open/close files

* Avoid growing `toDo` too eagerly

* @sheetalkamat code review

* Also get symlinked projects for originalLocation

* Update API (#24966)

* More @sheetalkamat code review

* Remove unnecessary test

* Update API (#24966)
ghost pushed a commit that referenced this issue Jul 9, 2018
Update API (#24966)
1efe323
ghost pushed a commit that referenced this issue Jul 10, 2018
getEditsForFileRename: Handle all projects and source-mapped files (#…
e9e5ebe 
…25522)

* getEditsForFileRename: Handle all projects and source-mapped files

* Update API (#24966)

* Use areEqual
ghost pushed a commit that referenced this issue Jul 11, 2018
Improve isPossiblyTypeArgumentPosition (#25043)
52486ae 
* Improve isPossiblyTypeArgumentPosition

* Update API (#24966)

* Handle new Type<Type<

* Add test for `new C < C<`
@mhegazy mhegazy assigned weswigham and unassigned RyanCavanaugh Jul 18, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 18, 2018

@weswigham can you take a look. we need a temporary fix for 3.0.1.

@mhegazy mhegazy mentioned this issue Jul 18, 2018
Closed
@weswigham
Copy link
Member

@mhegazy I think this was fixed by @rbuckton in #25556.

@ghost ghost closed this as completed Jul 20, 2018
@ghost ghost added the Fixed A PR has been merged for this issue label Jul 20, 2018
ghost pushed a commit that referenced this issue Sep 5, 2018
Remove duplicate function createTextRange (#23346)
bcb815b 
* Remove duplicate function createTextRange

* Always allow end=-1

* Put noAssert back, pending #23370

* Use getRangeUnion helper

* Update API (#24966)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
TypeScript 3.0.1
Development

No branches or pull requests
3 participants
@weswigham @RyanCavanaugh @mhegazy