Fix --strictNullChecks error with getDefaultProjectForFile #25060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
that referenced
this pull request
Jun 18, 2018
ghost
force-pushed
the
ensureDefaultProjectForFile
branch
from
b5bac59 to
a94e57f
Compare
mhegazy
reviewed
Jun 21, 2018
src/server/editorServices.ts
Outdated
| return ensureProject ? this.ensureDefaultProjectForFile(fileName) : this.tryGetDefaultProjectForFile(fileName); | ||
| } | ||
|
|
||
| tryGetDefaultProjectForFile(fileName: NormalizedPath): Project | undefined { |
There was a problem hiding this comment.
i would mark these as /* @internal */. both tryGetDefaultProjectForFile and ensureDefaultProjectForFile
mhegazy
approved these changes
Jun 21, 2018
sheetalkamat
approved these changes
Jun 22, 2018
ghost
pushed a commit
that referenced
this pull request
Jun 25, 2018
) * Make GetEditsForFileRenameRequestArgs not extend FileRequestArgs * Code review: check new location first, and use scriptInfo.getDefaultProject() * Remove changes to e getDefaultProjectForFile (now #25060) * Undo API changes (#24966) * Combine edits from all projects (fixes #25052) * Update API (#24966) * Ignore orphan projects or projects with language service disabled
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially two different functions with a flag to choose between them. Now that we have
--strictNullChecks, this is a problem because the return type needs to be different in each case. This PR breaks out the two separate functions which can be called directly.