Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recommend to install '@types/foo' if that already exists #24815

Merged
4 commits merged into from
Jun 21, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 8, 2018

Fixes #24781

@ghost ghost requested a review from DanielRosenwasser June 8, 2018 23:42
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 9, 2018

Almost there - I think it'd be helpful to say that if this resolved from an @types location, that we should elaborate with

If the '{0}' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/{0}`

@ghost ghost merged commit 2b9166b into master Jun 21, 2018
@ghost ghost deleted the untypedModuleImport_noImplicitAny_typesForPackageExist branch June 21, 2018 17:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants