ChangeTracker: Combine deleteDeclaration, deleteNode, and deleteNodeInList #25276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
mhegazy
reviewed
Jun 29, 2018
src/services/textChanges.ts
Outdated
| this.deleteRange(sourceFile, { pos: startPosition, end: endPosition }); | ||
| return this; | ||
| delete(sourceFile: SourceFile, node: Node): void { | ||
| this.deletedDeclarations.push({ sourceFile, node, }); |
There was a problem hiding this comment.
i would call this deletedNodes, since nothing ensures they are a declaration
mhegazy
approved these changes
Jun 29, 2018
added 2 commits
June 29, 2018 19:30
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #25011 -- that added a new deletion method. As of this PR, you can just call
deleteand ChangeTracker should be smart enough to know what kind of deletion to do.