Modernize Jakefile + fix project references breaks #24938
Conversation
|
CI failures are just node6 OOMing as usual |
|
@RyanCavanaugh node6 doesn't usually OOM; it usually just times out, and usually only on travis (as we've never had the issue on VSTS), AFAIK (and usually not repeatable if you rerun the build). I'd find consistent OOMs (even if confined to one version) fairly concerning; it probably means that on that version we OOM but on the others we're close to being OOM. |
|
For reference, in @rbuckton can probably relate, considering he's already had to acknowledge that running all the builds in one processes like that isn't possible when running under |
|
K, investigating the memory thing |
# Conflicts: # tests/baselines/reference/api/typescript.d.ts
ghost
mentioned this pull request
Jakefile.js
Outdated
| exec(`${host} ${Paths.scripts.produceLKG}`, () => { | ||
| const sizeAfter = getDirSize(Paths.lkg); | ||
| if (sizeAfter > (sizeBefore * 1.10)) { | ||
| // throw new Error("The lib folder increased by 10% or more. This likely indicates a bug."); |
There was a problem hiding this comment.
Looks like the Error should go back in and the console.log should go away.
Jakefile.js
Outdated
| ex.run(); | ||
| } | ||
| /* | ||
| file(Paths.tsserverLibraryDefinitionFile, [TaskNames.coreBuild, Paths.copyright, ...libraryTargets], function () { |
| @@ -45,7 +45,7 @@ | |||
| "@types/minimatch": "latest", | |||
| "@types/minimist": "latest", | |||
| "@types/mkdirp": "latest", | |||
| "@types/mocha": "latest", | |||
| "@types/mocha": "^5.2.2", | |||
There was a problem hiding this comment.
are the changes in package.json intentional?
src/compiler/tsbuild.ts
Outdated
| @@ -1095,16 +1109,18 @@ namespace ts { | |||
| return resolvedNames; | |||
| } | |||
|
|
|||
| function buildAllProjects() { | |||
| function buildAllProjects(): number { | |||
There was a problem hiding this comment.
why isn't this return type ExitStatus?
| @@ -1,19 +0,0 @@ | |||
| { | |||
| "extends": "../tsconfig-base", | |||
There was a problem hiding this comment.
what are these files replaced by (if anything)?
Jakefile.js
Outdated
| var nodeServerInFile = "tests/webTestServer.ts"; | ||
| compileFile(nodeServerOutFile, [nodeServerInFile], [builtLocalDirectory, tscFile], [], /*useBuiltCompiler:*/ true, { noOutFile: true, lib: "es6" }); | ||
| jake.mkdirP(Paths.baselines.local); | ||
| jake.mkdirP(Paths.baselines.localRwc); |
There was a problem hiding this comment.
This is going to make an internal folder for people without internal checked out. We probably don't want that.
# Conflicts: # tests/baselines/reference/api/typescript.d.ts
|
Apparently we are no longer writing out typescript.js in the jake builds. |
Merges parser, core, and compiler back into compiler per request
Rewrites the Jakefile and fixes a variety of tsbuild bugs.
Includes LKG update; see me offline for an analysis of what's i nthere