Improve isPossiblyTypeArgumentPosition #25043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from |
|
||
| export function getPossibleGenericSignatures(called: Expression, typeArgumentCount: number, checker: TypeChecker): ReadonlyArray<Signature> { | ||
| const type = checker.getTypeAtLocation(called)!; // TODO: GH#18217 | ||
| const signatures = isNewExpression(called.parent) ? type.getConstructSignatures() : type.getCallSignatures(); |
There was a problem hiding this comment.
the whole purpose of this function was to do syntactic scan on tokens since the tree cant be guaranteed. Eg. what if someone was writing new Type<Type<
There was a problem hiding this comment.
Isn't this still issue with generic signature help? Create a type that has construct and call signature and see that in case of new C<C< the signature help should return construct signature but this will return call signature?
|
@sheetalkamat Please re-review |
sheetalkamat
approved these changes
Jul 11, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23631
We will no longer return type completions at
x <wherexis not a generic function.