More thoroughly test navigateTo #25239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 26, 2018
| @@ -1592,16 +1592,15 @@ namespace ts.server { | |||
| const bakedItem: protocol.NavtoItem = { | |||
| name: navItem.name, | |||
| kind: navItem.kind, | |||
| isCaseSensitive: navItem.isCaseSensitive, | |||
| matchKind: navItem.matchKind, | |||
| file: navItem.fileName, | |||
| start: scriptInfo.positionToLineOffset(navItem.textSpan.start), | |||
| end: scriptInfo.positionToLineOffset(textSpanEnd(navItem.textSpan)) | |||
| }; | |||
| if (navItem.kindModifiers && (navItem.kindModifiers !== "")) { | |||
| bakedItem.kindModifiers = navItem.kindModifiers; | |||
| } | |||
There was a problem hiding this comment.
"none" wasn't a possible value (detected by changing the type to a string literal union), so in practice matchKind would always be set.
ghost
commented
Jun 26, 2018
| @@ -1592,16 +1592,15 @@ namespace ts.server { | |||
| const bakedItem: protocol.NavtoItem = { | |||
| name: navItem.name, | |||
| kind: navItem.kind, | |||
| isCaseSensitive: navItem.isCaseSensitive, | |||
There was a problem hiding this comment.
isCaseSensitive was declared optional but we never set it anywhere.
ghost
requested a review
from
This was referenced Jun 26, 2018
ghost
changed the title
mhegazy
approved these changes
Jul 2, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just testing the number of items,
assert.deepEqualthe exact contents of the response.Also fixes a bug where
kindModifierscould be undefined when passed throughclient.ts(should be"").Discovered #25233 and #25237.