Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsserverlibrary.js needs to be kept up-to-date in the LKG #25131

Closed
weswigham opened this issue Jun 21, 2018 · 3 comments
Closed

tsserverlibrary.js needs to be kept up-to-date in the LKG #25131

weswigham opened this issue Jun 21, 2018 · 3 comments
Assignees
Labels
Bug A bug in TypeScript High Priority

Comments

@weswigham
Copy link
Member

We don't use it internally, but we ship it so consumers can package their own tsserver for whatever environment suits them (ie, browser extension). We have had issues opened before when we've outright broken it, so it being out-of-date is also likely an issue. (Specifically, if that old issue is any indication, we'll break webstorm by not updating it or removing it)

@mhegazy mhegazy changed the title tsserverlibrary.js needs to be kept to-to-date in the LKG tsserverlibrary.js needs to be kept up-to-date in the LKG Jun 21, 2018
@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 21, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 21, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jun 21, 2018

@RyanCavanaugh can you take a look.

@weswigham
Copy link
Member Author

Please note, its declaration file also needs the stripInternal treatment, or we expose our internals in its API (and we are right now, which isn't great).

@mhegazy
Copy link
Contributor

mhegazy commented Jul 18, 2018

Already tracked by #24966

@mhegazy mhegazy closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript High Priority
Projects
None yet
Development

No branches or pull requests

3 participants