Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🎨 import type when it's only used as type #532

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Mar 5, 2025

What type of PR is this?

  • Refactor

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: justify why you didn't add tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Mar 5, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.84% 2597 / 3061
🔵 Statements 84.84% 2597 / 3061
🔵 Functions 81.88% 208 / 254
🔵 Branches 82.3% 642 / 780
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/logger/src/index.ts 100% 80% 100% 100%
packages/node/src/handlers.ts 85.44% 70.73% 92.85% 85.44% 59-61, 66-68, 72-73, 87-89, 106, 113-114, 117-119, 121-123, 138-143, 150-152, 167-169, 173, 181, 203, 222-224, 258, 270-272, 276, 316, 321-326, 357, 361, 366, 378-379, 457-459
packages/node/src/index.ts 74.52% 66.66% 57.14% 74.52% 58-59, 62-66, 69-75, 78-79, 82-88, 111-112, 140-141
packages/node/src/logger.ts 100% 100% 0% 100%
packages/node/src/operations.ts 94.04% 86.66% 100% 94.04% 43, 80-81, 106-107
packages/object/src/index.ts 91.88% 82.67% 100% 91.88% 162-163, 167, 184-185, 201-203, 238-239, 272-273, 348-352, 356-357, 362-363, 373-374, 382-383, 409-410, 418-419, 428-429, 440-441, 507-508, 520-521
packages/object/src/interface.ts 100% 100% 100% 100%
packages/object/src/finality/index.ts 95.65% 92.5% 100% 95.65% 71-72, 120-121, 161-162
packages/object/src/hashgraph/index.ts 79.31% 75.6% 70% 79.31% 97-100, 224, 226, 232-233, 235-237, 242-243, 254-255, 273-275, 278-280, 284-286, 299-301, 314, 319-320, 337-366, 369-373, 380-381, 384-385, 392-393, 396-397
packages/object/src/linearize/multipleSemantics.ts 83.52% 73.07% 100% 83.52% 15-22, 52-54, 80-81, 88
packages/object/src/linearize/pairSemantics.ts 96.55% 95.65% 100% 96.55% 42-43
packages/types/src/interval-runner.ts 0% 0% 0% 0%
packages/types/src/logger.ts 0% 0% 0% 0%
Generated in workflow #2232 for commit 229c513 by the Vitest Coverage Report Action

Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit 5d85a0f into main Mar 5, 2025
14 checks passed
@sfroment sfroment deleted the fix/add-type-import-rules branch March 5, 2025 11:52
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)

Signed-off-by: Sacha Froment <[email protected]>
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
  fix: import plugin wasn't activated for typescript (#523)
  fix: readme link (#526)
  fix: version (#525)
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
sfroment added a commit that referenced this pull request Mar 11, 2025
* origin: (51 commits)
  feat: update object acl  (#536)
  refactor: update linearization to return vertices (#552)
  fix: shared admin permission (#545)
  fix: writer permission check (#543)
  chore: release v0.9.2
  fix: add tsx to the deps
  refactor: 🎨 import are now sorted (#548)
  chore: release v0.9.1
  fix: keychain git url
  chore: release v0.9.0
  fix: update peer-id (#547)
  fix: use sha512 (#546)
  fix: exclude dist (#541)
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants