Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import plugin wasn't activated for typescript #523

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

sfroment
Copy link
Member

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Bug Fix

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: justify why you didn't add tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@sfroment
Copy link
Member Author

sfroment commented Feb 28, 2025

This will need to wait for libp2p/js-libp2p#3018
Then I also need to fix

/topology/drp-lint/packages/node/src/handlers.ts
  20:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/node/src/index.ts
  10:1  error  Dependency cycle detected  import/no-cycle
  11:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/node/src/operations.ts
  6:1  error  Dependency cycle via ./index.js:20  import/no-cycle

/topology/drp-lint/packages/object/src/acl/index.ts
  3:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/object/src/finality/index.ts
  7:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/object/src/hashgraph/index.ts
  3:1  error  Dependency cycle detected  import/no-cycle
  5:1  error  Dependency cycle detected  import/no-cycle
  6:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/object/src/index.ts
   8:1  error  Dependency cycle detected  import/no-cycle
  10:1  error  Dependency cycle detected  import/no-cycle
  11:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/object/src/linearize/multipleSemantics.ts
  3:1  error  Dependency cycle detected  import/no-cycle

/topology/drp-lint/packages/object/src/linearize/pairSemantics.ts
  3:1  error  Dependency cycle detected  import/no-cycle

I already have a branch where all this is fixed but I will do it small pieces by pieces

Copy link

github-actions bot commented Feb 28, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment force-pushed the fix/lint-import branch 2 times, most recently from cf655ea to e432fdb Compare March 3, 2025 14:53
Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment merged commit 5d21789 into main Mar 3, 2025
14 checks passed
@sfroment sfroment deleted the fix/lint-import branch March 3, 2025 15:36
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
  fix: import plugin wasn't activated for typescript (#523)
  fix: readme link (#526)
  fix: version (#525)
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants