Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace eddsa with ecdsa #492

Merged
merged 34 commits into from
Mar 4, 2025
Merged

Conversation

trungnotchung
Copy link
Member

@trungnotchung trungnotchung commented Feb 19, 2025

What type of PR is this?

  • Feature

Description

  • Changed Keychain private key from eddsa to ecdsa
  • Verify vertices using the signature, hash data, and peerId instead of using the public key
  • Verify vertices when the acl is missing
  • Updated BOOTSTRAP_NODES peerIDs and default peerIDs
  • Added tests for Keychain and its functions
  • Updated relevant tests

Related Issues and PRs

Added/updated tests?

  • Yes

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

  • [Yes], we need to redeploy the bootstrap nodes

Copy link

github-actions bot commented Feb 19, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@trungnotchung trungnotchung force-pushed the feat/replace-eddsa-with-ecdsa branch from c5bfe7b to 4bb862c Compare February 22, 2025 10:41
@trungnotchung trungnotchung marked this pull request as ready for review February 25, 2025 05:11
@d-roak d-roak removed the request for review from hoangquocvietuet February 25, 2025 06:39
@trungnotchung trungnotchung marked this pull request as draft February 26, 2025 11:05
@trungnotchung trungnotchung marked this pull request as ready for review March 3, 2025 09:52
@trungnotchung trungnotchung force-pushed the feat/replace-eddsa-with-ecdsa branch from b235b00 to c6b579d Compare March 3, 2025 11:10
Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the peer id in config/bootstrap.json and lgtm

Copy link
Contributor

@winprn winprn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the PR so that we will remember to update our remote bootstrap nodes to reflect their new peer ID

sfroment added 2 commits March 4, 2025 16:49
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment merged commit 9da595a into main Mar 4, 2025
14 checks passed
@sfroment sfroment deleted the feat/replace-eddsa-with-ecdsa branch March 4, 2025 16:19
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
  fix: import plugin wasn't activated for typescript (#523)
  fix: readme link (#526)
  fix: version (#525)
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Replace EdDSA with ECDSA for vertex cryptographic signing function
4 participants