refactor: remove addToFrontier #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
trungnotchung
requested review from
JanLewDev,
winprn and
magnified103
as code owners
anhnd350309
approved these changes
Mar 5, 2025
JanLewDev
approved these changes
Mar 5, 2025
sfroment
added a commit
that referenced
this pull request
Mar 5, 2025
sfroment
added a commit
that referenced
this pull request
Mar 5, 2025
* origin: refactor: remove unused args (#534) refactor: 🎨 import type when it's only used as type (#532) fix(coverage): 🐛 remove version.ts from coverage (#531) feat: add interval-runner (#524) refactor: remove addToFrontier (#530) Feat: enhance coverage (#493) Signed-off-by: Sacha Froment <[email protected]>
sfroment
added a commit
that referenced
this pull request
Mar 6, 2025
* origin: refactor: 🚨 better promise usage and type on function (#535) refactor: remove unused args (#534) refactor: 🎨 import type when it's only used as type (#532) fix(coverage): 🐛 remove version.ts from coverage (#531) feat: add interval-runner (#524) refactor: remove addToFrontier (#530) Feat: enhance coverage (#493) feat: replace eddsa with ecdsa (#492) fix: import plugin wasn't activated for typescript (#523) fix: readme link (#526) fix: version (#525) fix: linting deps not at the correct place (#519) feat: add readme.md for package keychain (#521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, the functions
addToFrontierandaddVertexare the same. Remove functionaddToFrontierand useaddVertexwhen a new operation is applied locally to make it easier to maintain the codebase.Related Issues and PRs
Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?