Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting deps not at the correct place #519

Merged
merged 4 commits into from
Mar 3, 2025
Merged

fix: linting deps not at the correct place #519

merged 4 commits into from
Mar 3, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Feb 26, 2025

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • Yes
  • No, because why: justify why you didn't add tests
  • I need help with writing tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 26, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@sfroment sfroment force-pushed the fix/lint branch 2 times, most recently from 0357848 to 94f32d4 Compare February 26, 2025 15:51
Signed-off-by: Sacha Froment <[email protected]>
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment requested a review from d-roak March 3, 2025 09:13
@sfroment sfroment merged commit e70c8dc into main Mar 3, 2025
14 checks passed
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment deleted the fix/lint branch March 3, 2025 10:47
sfroment added a commit that referenced this pull request Mar 3, 2025
* origin:
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
  fix: import plugin wasn't activated for typescript (#523)
  fix: readme link (#526)
  fix: version (#525)
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants