Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: enhance coverage #493

Merged
merged 23 commits into from
Mar 5, 2025
Merged

Feat: enhance coverage #493

merged 23 commits into from
Mar 5, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Feb 19, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • More test case (85%)
  • add view test case coverage in PR )

Related Issues and PRs

Added/updated tests?

  • Yes: add plenty of testcase
  • No, because why: justify why you didn't add tests
  • I need help with writing tests

Additional Info

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Feb 20, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Feb 20, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.6% 2534 / 2995
🔵 Statements 84.6% 2534 / 2995
🔵 Functions 81.45% 202 / 248
🔵 Branches 81.96% 618 / 754
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/node/src/index.ts 74.52% 66.66% 57.14% 74.52% 58-59, 62-66, 69-75, 78-79, 82-88, 111-112, 140-141
packages/node/src/run.ts 100% 100% 100% 100%
packages/node/src/rpc/index.ts 24.48% 100% 12.5% 24.48% 24-41, 44-59, 62-81, 84-99, 102-117, 120-135, 138-153
Generated in workflow #2221 for commit 6a2435a by the Vitest Coverage Report Action

@anhnd350309 anhnd350309 changed the title Feat/enhance coverage Feat: enhance coverage Feb 20, 2025
@anhnd350309 anhnd350309 force-pushed the feat/enhance-coverage branch from d716e82 to 1f6f789 Compare February 20, 2025 15:26
@anhnd350309 anhnd350309 force-pushed the feat/enhance-coverage branch from c538d13 to 9aa1447 Compare February 27, 2025 06:56
@anhnd350309 anhnd350309 marked this pull request as ready for review February 27, 2025 06:56
@anhnd350309 anhnd350309 force-pushed the feat/enhance-coverage branch from 84072e3 to 37f46ca Compare March 4, 2025 15:40
@sfroment sfroment merged commit 9d0aa43 into main Mar 5, 2025
14 checks passed
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
sfroment added a commit that referenced this pull request Mar 5, 2025
* origin:
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)

Signed-off-by: Sacha Froment <[email protected]>
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  feat: add interval-runner (#524)
  refactor: remove addToFrontier (#530)
  Feat: enhance coverage (#493)
  feat: replace eddsa with ecdsa (#492)
  fix: import plugin wasn't activated for typescript (#523)
  fix: readme link (#526)
  fix: version (#525)
  fix: linting deps not at the correct place (#519)
  feat: add readme.md for package keychain (#521)
@d-roak d-roak deleted the feat/enhance-coverage branch March 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants