Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add typecheck workflow #540

Merged
merged 8 commits into from
Mar 7, 2025
Merged

fix: add typecheck workflow #540

merged 8 commits into from
Mar 7, 2025

Conversation

sfroment
Copy link
Member

@sfroment sfroment commented Mar 6, 2025

  • chore: fix test
  • chore: fix examples
  • chore: fix lock
  • chore: add typecheck workflow

What type of PR is this?

  • Bug Fix

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: justify why you didn't add tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

sfroment added 4 commits March 6, 2025 17:41
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Copy link

github-actions bot commented Mar 6, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.55% 2576 / 3083
🔵 Statements 83.55% 2576 / 3083
🔵 Functions 81.91% 222 / 271
🔵 Branches 82.05% 640 / 780
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/node/src/config.ts 27.27% 33.33% 100% 27.27% 9-11, 15-35
packages/node/src/handlers.ts 86.57% 71.79% 92.85% 86.57% 93-95, 112, 120-121, 124-126, 128-130, 145-150, 158-160, 177-179, 183, 213, 227-229, 235-237, 271, 281-283, 288-290, 294, 334, 339-344, 375, 379, 384, 396-397, 480-482
packages/node/src/index.ts 72.72% 66.66% 57.14% 72.72% 62-63, 66-70, 73-79, 82-86, 89-95, 118-119, 147-148
packages/node/src/run.ts 100% 100% 100% 100%
packages/object/src/utils/serializer.ts 100% 90% 100% 100%
Generated in workflow #2285 for commit ec5744b by the Vitest Coverage Report Action

Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>

chore: --

Signed-off-by: Sacha Froment <[email protected]>

chore: --

Signed-off-by: Sacha Froment <[email protected]>

chore: --

Signed-off-by: Sacha Froment <[email protected]>

chore: --

Signed-off-by: Sacha Froment <[email protected]>

chore: --

Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit 3377ee2 into main Mar 7, 2025
15 checks passed
sfroment added a commit that referenced this pull request Mar 7, 2025
sfroment added a commit that referenced this pull request Mar 7, 2025
* origin:
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
sfroment added a commit that referenced this pull request Mar 7, 2025
* origin:
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)

Signed-off-by: Sacha Froment <[email protected]>
sfroment added a commit that referenced this pull request Mar 11, 2025
* origin: (51 commits)
  feat: update object acl  (#536)
  refactor: update linearization to return vertices (#552)
  fix: shared admin permission (#545)
  fix: writer permission check (#543)
  chore: release v0.9.2
  fix: add tsx to the deps
  refactor: 🎨 import are now sorted (#548)
  chore: release v0.9.1
  fix: keychain git url
  chore: release v0.9.0
  fix: update peer-id (#547)
  fix: use sha512 (#546)
  fix: exclude dist (#541)
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  ...
@d-roak d-roak deleted the fix/lint-2 branch March 11, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants