Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Strategy handle message #537

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Refactor: Strategy handle message #537

merged 8 commits into from
Mar 6, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Mar 6, 2025

What type of PR is this?

Refactor Handler, make strategy pattern to handle message

  • Refactor

Description

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: just refactor

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@anhnd350309 anhnd350309 changed the title init run handler strategy Refactor: Strategy Handle message Mar 6, 2025
@anhnd350309 anhnd350309 changed the title Refactor: Strategy Handle message Refactor: Strategy handle message Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.37% 2602 / 3084
🔵 Statements 84.37% 2602 / 3084
🔵 Functions 81.46% 211 / 259
🔵 Branches 82.12% 643 / 783
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/node/src/handlers.ts 86.17% 70.12% 92.85% 86.17% 91-93, 110, 118-119, 122-124, 126-128, 143-148, 156-158, 175-177, 181, 189, 211, 225-227, 233-235, 269, 279-281, 286-288, 292, 332, 337-342, 373, 377, 382, 394-395, 474-476
Generated in workflow #2259 for commit 0429d54 by the Vitest Coverage Report Action

@anhnd350309 anhnd350309 marked this pull request as ready for review March 6, 2025 11:13
Copy link
Member

@sfroment sfroment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way cleaner already

sfroment added 3 commits March 6, 2025 14:37
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
@sfroment sfroment merged commit 9661822 into main Mar 6, 2025
14 checks passed
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  Refactor: Strategy handle message (#537)
sfroment added a commit that referenced this pull request Mar 6, 2025
* origin:
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
sfroment added a commit that referenced this pull request Mar 7, 2025
* origin:
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
sfroment added a commit that referenced this pull request Mar 7, 2025
* origin:
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
sfroment added a commit that referenced this pull request Mar 7, 2025
* origin:
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)

Signed-off-by: Sacha Froment <[email protected]>
sfroment added a commit that referenced this pull request Mar 11, 2025
* origin: (51 commits)
  feat: update object acl  (#536)
  refactor: update linearization to return vertices (#552)
  fix: shared admin permission (#545)
  fix: writer permission check (#543)
  chore: release v0.9.2
  fix: add tsx to the deps
  refactor: 🎨 import are now sorted (#548)
  chore: release v0.9.1
  fix: keychain git url
  chore: release v0.9.0
  fix: update peer-id (#547)
  fix: use sha512 (#546)
  fix: exclude dist (#541)
  fix: add typecheck workflow (#540)
  feat: add main types (#527)
  Refactor: Strategy handle message (#537)
  refactor: 🚨 better promise usage and type on function (#535)
  refactor: remove unused args (#534)
  refactor: 🎨 import type when it's only used as type (#532)
  fix(coverage): 🐛 remove version.ts from coverage (#531)
  ...
@d-roak d-roak deleted the refactor/handle branch March 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants