-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Strategy handle message #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
Coverage Report
File Coverage
|
5d928aa
to
565c534
Compare
sfroment
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
way cleaner already
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
sfroment
approved these changes
Mar 6, 2025
sfroment
added a commit
that referenced
this pull request
Mar 6, 2025
* origin: Refactor: Strategy handle message (#537)
sfroment
added a commit
that referenced
this pull request
Mar 7, 2025
* origin: fix: add typecheck workflow (#540) feat: add main types (#527) Refactor: Strategy handle message (#537) Signed-off-by: Sacha Froment <[email protected]>
sfroment
added a commit
that referenced
this pull request
Mar 11, 2025
* origin: (51 commits) feat: update object acl (#536) refactor: update linearization to return vertices (#552) fix: shared admin permission (#545) fix: writer permission check (#543) chore: release v0.9.2 fix: add tsx to the deps refactor: 🎨 import are now sorted (#548) chore: release v0.9.1 fix: keychain git url chore: release v0.9.0 fix: update peer-id (#547) fix: use sha512 (#546) fix: exclude dist (#541) fix: add typecheck workflow (#540) feat: add main types (#527) Refactor: Strategy handle message (#537) refactor: 🚨 better promise usage and type on function (#535) refactor: remove unused args (#534) refactor: 🎨 import type when it's only used as type (#532) fix(coverage): 🐛 remove version.ts from coverage (#531) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactor Handler, make strategy pattern to handle message
Description
Related Issues and PRs
Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?