Release 1.2.0 #1341

katspaugh · 2022-12-09T14:44:24Z

Features

[Epic] Transaction replacement ([Epic] Transaction replacement #1079)
[Epic] Governance visibility ([Epic] Governance visibility #1256)
feat(safe-apps): Add custom Safe App warning (feat(safe-apps): Add custom Safe App warning #1258)
Added sandbox attribute to Safe App iframe (Added sandbox attribute to Safe App iframe #1252)

Bug fixes

fix: Change status colors in safe creation (fix: Change status colors in safe creation #1339)
fix: allow resetting to recommended nonce of 0 (fix: allow resetting to recommended nonce of 0 #1329)
fix: alter threshold change warning text (fix: alter threshold change warning text #1332)
fix: Track safe cretion events under the same category (fix: Track safe creation events under the same category #1312)
fix: Reset Core SDK when switching safes (fix: Reset Core SDK when switching safes #1259)
Fix format amount review modal (Fix format amount review modal #1265)
Fix: div inside p (Fix: div inside p #1322)
fix: get fallback handler from SDK (fix: get Compatibility Fallback Handler from SDK #1282)
fix: redesign (external) links (feat: redesign (external) links #1241)
refactor: use isValidTransaction from SDK (refactor: use isValidTransaction from SDK #1285)
fix: Revert accordion transitions (fix: Revert accordion transitions #1304)
fix: fallback to "Contract interaction" for module (fix: fallback to "Contract interaction" for module #1301)
fix: prevent scroll adjusting number inputs (fix: prevent scroll adjusting number inputs #1280)
fix: vertical scrolling after opening the Mobile paring modal (fix: vertical scrolling after opening the Mobile paring modal #1295)
fix: Handle timeout error in safe creation (fix: Handle timeout error in safe creation #1293)
Fix: link to old app from the import page (Fix: link to old app from the import page #1306)
fix: Account switching with mobile pairing and WC (fix: Account switching with mobile pairing and WC #1278)
add safe token address to goerli (add safe token address to goerli #1274)
fix(safe-apps): Rename transaction confirmed event to propose transaction (fix(safe-apps): Rename transaction confirmed event to propose transaction #1263)
Import Safe Core SDK from @safe-global (Import Safe Core SDK from @safe-global #1266)
fix: adjust text of buttons in transfer modal #1342
fix: handle nullable SafeInfo['version'] #1340
fix: Replacement modal button alignment on mobile #1363
fix: change custom tx fallback icon #1360
fix: take native number validation into account #1368

Chores

Chore: migrate gateway sdk package to safe-global (Chore: migrate gateway sdk package to safe-global #1333)
Chore: add a CLA checking action (Chore: add a CLA checking action #1292)
Chore: a new domain for PR deployment (Chore: a new domain for PR deployment #1271)
Chore: use branch name for PR deployments + prettify the comment (Chore: use branch name for PR deployments + prettify the comment #1288)

…tion (#1263)

* Added sandbox attribute to Safe App iframe * added allow-popups-to-escape-sandbox

* Chore: add a QR code to PR deployment comment * Add a pre-deploy comment * Message id * ref_name * Branch name * Replace slashes * add-pr-comment@v2 * head_ref

* fix: Account switching with mobile pairing and WC * chore: Add TODO

* Chore: add a CLA checking action * Rm myself to test * Refs * PR trigger * Tweak the if * Restore myself

* Chore: tune the CLA action * pull_request_target -> pull_request * Access token * Rm optional params * Lock after merge * Copy CLA into an md file

* Fix: link to old app from the import page * path-to-signatures * CLA contains * Revert conditional alert

* fix: Handle timeout error in safe creation * fix: Failing tests, adjust isContractError * chore: Add TODO

* feat: replace specific transactions (#1053) * feat: replace specific transactions * fix: cleanup code * fix: update title * style: change `variant` * fix: replacing `0` nonced transactions * feat: add autocomplete to `NonceForm` nonce (#1059) * feat: replacement modal (#1132) * feat: replace transaction modal w/ stepper * fix: adjust text + padding/margins * fix: adjust alignment + add mobile view * fix: alignment * fix: tweak autocomplete item text * fix: shorten text + add `Backdrop` * Merge branch 'dev' into tx-replacement * fix: replace nonce 0, flicker, no spending limit + disable duplite rejections (#1300) * fix: replace nonce 0, flicker + no spending limit * fix: always allow replacement + nonce `0` * fix: remove tag * Rm backdrop Co-authored-by: katspaugh <[email protected]> Co-authored-by: katspaugh <[email protected]>

* Chore: replace the CLA action with a simple comment * Test the comment * Detect signature comment * Trigger on comment

* chore: fix vertical scrolling after opening the Mobile paring modal * cheking CLA * alternative fix: make Dialog a controlled component Co-authored-by: katspaugh <[email protected]>

* fix: blur number inputs `onWheel` events * fix: remove duplicate attribute * fix: use `inputMode` and `pattern` * fix: use `type` attribute + replace more fields * fix: missing field * fix: remove attribute

* Chore: try a different CLA config * Update allowlist

* fix: format review amount to locale * add truncating trailing zeros to the formater. tests * use toLocaleString instead of regex to format the integer part of amount * use the common formatter for token amounts in the review modal heasder * precision formatter without using the style guide * add tests to new formatter * rm redundant code

* fix: Only initialize the Core SDK once * fix: Hide Send button in Address book if wrong network * fix: Add tests for useInitSafeCoreSDK hook * refactor: useInitSafeCoreSDK hook * refactor: Rename initSafeSDK param * fix: Reset core sdk when switching safes * fix: Add safeSDK dependency for safe app modals * Refactor: useTxSender * fix: Adjust imports * refactor: Use useTxSender hook in components * fix: Handle undefined values in SignOrExecuteForm * refactor: Extract spending limit tx to the tx sender * fix: Failing tests * fix: Add useTxSender functions to dependency arrays * fix: Better type useTxSender hook * fix: Remove ts-ignore * fix: Remove async from undefined function Co-authored-by: katspaugh <[email protected]>

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

github-actions · 2022-12-09T14:44:44Z

Branch preview

✅ Deploy successful!

https://release120--webcore.review-web-core.5afe.dev

github-actions · 2022-12-09T14:47:36Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

katspaugh · 2022-12-09T16:43:11Z

As @schmanu mentioned, we need to release the Claiming App before we release this.

* fix: adjust text of buttons in transfer modal * fix: adjust text * Update src/components/tx/modals/NewTxModal/ReplacementModal.tsx Co-authored-by: katspaugh <[email protected]>

liliya-soroka · 2022-12-12T11:33:54Z

Regression issue = #1353

Text is displayed inside amount field
-Go to the send funds

enter 1. to the amount field

liliya-soroka · 2022-12-12T12:15:20Z

Regression issue - #1354
2. module tx is not fixed fully - fix: fallback to "Contract interaction" for module (#1301)
Settings icon is used instead of contract interaction

JagoFigueroa · 2022-12-12T16:20:03Z

Regression issue - #1355
3. Hola team! For this ticket regarding timeouts on safe creation the expected result is shown to me after 6,5 minutes on the case that I reload the page:

but unfortunately on the case that I don't perform a manual page reload it will be stuck on this screen forever (I have waited for 20 minutes in chrome)

JagoFigueroa · 2022-12-13T09:03:59Z

Regression issue = #1356
4. Hola again! For this señor ticket regarding the export/import for this case mentioned on the ticket:

Show the "Overwrite data?" alert only after dropping a file

I can see that we are showing the alert before uploading the JSON file. Nothing major or anything but Is it expected?

Cheers!

JagoFigueroa · 2022-12-13T09:29:28Z

Regression issue = #1357
5. Regarding transaction replacement modal, presentation is a bit off when viewing it from a mobile device (video is from the browser but in mobile resolution I was able to reproduce this as well on my Iphone 13 pro):

replace.mobile.mp4

* fix: handle nullable `SafeInfo['version'] * fix: install + fix types w/ new package * fix: remove unnecessary optional chaining * fix: add fallback version text * fix: don't show link for unsupported contract

liliya-soroka · 2022-12-14T11:44:54Z

The 1.2.0 is approved for the release without - #1355, but we are waiting for the critical issue #1343 to be fixed, tested and included into 1.2.0

* fix: take native number validation into account * fix: remove native validation + revert to text

liliya-soroka · 2022-12-14T14:28:25Z

Thank you for the fixes. The 1.2.0 rc is approved to go live

germartinez and others added 30 commits November 29, 2022 08:41

Import Safe Core SDK from @safe-global (#1266)

33ae4fe

fix(safe-apps): Rename transaction confirmed event to propose transac…

f1fd212

…tion (#1263)

Added sandbox attribute to Safe App iframe (#1252)

d982bf6

* Added sandbox attribute to Safe App iframe * added allow-popups-to-escape-sandbox

Chore: a new domain for PR deployment (#1271)

2486dd3

add safe token address to goerli (#1274)

7823e6c

Merge branch 'main' of github.com:safe-global/web-core into dev

94cd4d4

feat(safe-apps): Add custom Safe App warning (#1258)

f222f51

Chore: use branch name for PR deployments + prettify the comment (#1288)

9026f50

* Chore: add a QR code to PR deployment comment * Add a pre-deploy comment * Message id * ref_name * Branch name * Replace slashes * add-pr-comment@v2 * head_ref

fix: Account switching with mobile pairing and WC (#1278)

c34012e

* fix: Account switching with mobile pairing and WC * chore: Add TODO

Chore: add a CLA checking action (#1292)

a65e1c9

* Chore: add a CLA checking action * Rm myself to test * Refs * PR trigger * Tweak the if * Restore myself

Chore: tune the CLA action (#1296)

5bd0f38

* Chore: tune the CLA action * pull_request_target -> pull_request * Access token * Rm optional params * Lock after merge * Copy CLA into an md file

Fix: link to old app from the import page (#1306)

d6fe73e

* Fix: link to old app from the import page * path-to-signatures * CLA contains * Revert conditional alert

Chore: use gnosis/github-action for CLA (#1308)

dd0f607

fix: Handle timeout error in safe creation (#1293)

6162cfd

* fix: Handle timeout error in safe creation * fix: Failing tests, adjust isContractError * chore: Add TODO

Chore: replace the CLA action with a simple comment (#1309)

9e1df31

* Chore: replace the CLA action with a simple comment * Test the comment * Detect signature comment * Trigger on comment

Chore: rm CLA workflow and update the PR template instead (#1313)

68cd5b8

fix: vertical scrolling after opening the Mobile paring modal (#1295)

edce31f

* chore: fix vertical scrolling after opening the Mobile paring modal * cheking CLA * alternative fix: make Dialog a controlled component Co-authored-by: katspaugh <[email protected]>

fix: prevent scroll adjusting number inputs (#1280)

637fd61

* fix: blur number inputs `onWheel` events * fix: remove duplicate attribute * fix: use `inputMode` and `pattern` * fix: use `type` attribute + replace more fields * fix: missing field * fix: remove attribute

fix: fallback to "Contract interaction" for module (#1301)

567b88b

Chore: try a different CLA config (#1314)

13ae32d

* Chore: try a different CLA config * Update allowlist

fix: Revert accordion transitions (#1304)

7c24ed4

refactor: use isValidTransaction from SDK (#1285)

73d70be

feat: redesign (external) links (#1241)

27f4f10

fix: get fallback handler from SDK (#1282)

5fc780a

Fix: div inside p (#1322)

2cf0712

fix: Track safe cretion events under the same category (#1312)

51239d7

schmanu mentioned this pull request Dec 12, 2022

chore: new release safe-global/safe-react-apps#610

Merged

iamacook and others added 2 commits December 12, 2022 10:37

fix: adjust text of buttons in transfer modal (#1342)

1229ef1

* fix: adjust text of buttons in transfer modal * fix: adjust text * Update src/components/tx/modals/NewTxModal/ReplacementModal.tsx Co-authored-by: katspaugh <[email protected]>

chore: Adjust branch deployment URLs (#1344)

a73ab24

Adjust safe token widget allocation formula (#1324)

9b9d1a4

iamacook and others added 3 commits December 13, 2022 13:01

fix: handle nullable SafeInfo['version'] (#1340)

a7f8712

* fix: handle nullable `SafeInfo['version'] * fix: install + fix types w/ new package * fix: remove unnecessary optional chaining * fix: add fallback version text * fix: don't show link for unsupported contract

fix: Replacement modal button alignment on mobile (#1363)

3e9aa7e

fix: change custom tx fallback icon (#1360)

174c6de

iamacook and others added 2 commits December 14, 2022 13:37

fix: take native number validation into account (#1368)

7e45176

* fix: take native number validation into account * fix: remove native validation + revert to text

Update safe-core-sdk to v3.2.1 (#1372)

d892513

usame-algan force-pushed the release/1.2.0 branch from b719aaf to d892513 Compare December 14, 2022 12:49

usame-algan approved these changes Dec 14, 2022

View reviewed changes

iamacook approved these changes Dec 15, 2022

View reviewed changes

katspaugh merged commit d892513 into main Dec 15, 2022

katspaugh deleted the release/1.2.0 branch December 15, 2022 09:13

github-actions bot locked and limited conversation to collaborators Dec 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.2.0 #1341

Release 1.2.0 #1341

katspaugh commented Dec 9, 2022 •

edited by usame-algan

Loading

github-actions bot commented Dec 9, 2022 •

edited

Loading

github-actions bot commented Dec 9, 2022 •

edited

Loading

katspaugh commented Dec 9, 2022

liliya-soroka commented Dec 12, 2022 •

edited

Loading

liliya-soroka commented Dec 12, 2022 •

edited

Loading

JagoFigueroa commented Dec 12, 2022 •

edited by liliya-soroka

Loading

JagoFigueroa commented Dec 13, 2022 •

edited by liliya-soroka

Loading

JagoFigueroa commented Dec 13, 2022 •

edited by liliya-soroka

Loading

liliya-soroka commented Dec 14, 2022

liliya-soroka commented Dec 14, 2022 •

edited

Loading

Release 1.2.0 #1341

Release 1.2.0 #1341

Conversation

katspaugh commented Dec 9, 2022 • edited by usame-algan Loading

Features

Bug fixes

Chores

github-actions bot commented Dec 9, 2022 • edited Loading

Branch preview

github-actions bot commented Dec 9, 2022 • edited Loading

ESLint Summary View Full Report

katspaugh commented Dec 9, 2022

liliya-soroka commented Dec 12, 2022 • edited Loading

liliya-soroka commented Dec 12, 2022 • edited Loading

JagoFigueroa commented Dec 12, 2022 • edited by liliya-soroka Loading

JagoFigueroa commented Dec 13, 2022 • edited by liliya-soroka Loading

JagoFigueroa commented Dec 13, 2022 • edited by liliya-soroka Loading

liliya-soroka commented Dec 14, 2022

liliya-soroka commented Dec 14, 2022 • edited Loading

katspaugh commented Dec 9, 2022 •

edited by usame-algan

Loading

github-actions bot commented Dec 9, 2022 •

edited

Loading

github-actions bot commented Dec 9, 2022 •

edited

Loading

liliya-soroka commented Dec 12, 2022 •

edited

Loading

liliya-soroka commented Dec 12, 2022 •

edited

Loading

JagoFigueroa commented Dec 12, 2022 •

edited by liliya-soroka

Loading

JagoFigueroa commented Dec 13, 2022 •

edited by liliya-soroka

Loading

JagoFigueroa commented Dec 13, 2022 •

edited by liliya-soroka

Loading

liliya-soroka commented Dec 14, 2022 •

edited

Loading