Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change custom tx fallback icon #1360

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Dec 13, 2022

What it solves

Resolves #1354

How this PR fixes it

change custom tx fallback icon

How to test it

Open eth:0x0DA0C3e52C977Ed3cBc641fF02DD271c3ED55aFe/transactions/tx?id=module_0x0DA0C3e52C977Ed3cBc641fF02DD271c3ED55aFe_0xe14278097fc7d0f462d2913d36185505ee09f8476ac899620c409eb0afaa812a_0xa65aaf534f1a4620 on production and observe the type be "Contract interaction".

Screenshots

Screenshot 2022-12-13 at 13 21 52

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

Branch preview

✅ Deploy successful!

https://fixchangecustomtxfallbackicon--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

Verified

@DiogoSoaress DiogoSoaress merged commit 174c6de into dev Dec 13, 2022
@DiogoSoaress DiogoSoaress deleted the fix-change-custom-tx-fallback-icon branch December 13, 2022 14:29
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 13, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

GitPOAP: 2022 Safe Web Core Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract interaction tx has settings icon
4 participants