fix: replace nonce 0, flicker, no spending limit + disable duplite rejections

[iamacook]

What it solves

Resolves isses found here.

How this PR fixes it

1. Spending limit transactions are not shown creating a transaction via the replacement flow.
2. The backdrop no longer flickers whent the autocomplete dropdown is open.
3. Transactions with nonce 0 now open the replacement modal.
4. Disable duplicate rejection transactions.

How to test it

1. Attempt to replace a transaction. Observe that spending limit options are not displayed.
2. Open the nonce autocomplete limit and observe no backdrop flicker.
3. Attempt to replace a transaction with nonce 0. Clicking "Replace transaction" in the modal should open the next step.
4. The replacement button is now always shown. Attempting to replace a transaction that already has a rejection transaction will render a disabled rejeection button in the modal.

[github-actions]

Branch preview

✅ Deploy successful!

https://tx-replacement-fixes--webcore.review-web-core.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[katspaugh]

An interesting workaround, but have you figured out why the flicker happens specifically with this dropdown?

[iamacook]

It's related to the gas price polling here. The Backdrop seems to be very tempermental between renders.

[katspaugh]

Sounds like the polling re-renders more than necessary in that form. I would take another look at that.

[katspaugh]

I deleted the backdrop entirely. It now looks the same as the AddressBookInput. Just a dropdown.

[iamacook]

Without the Backdrop, the options blur into the background though. It was suggested here:

cc @usame-algan

[francovenica]

The three issues fixed in this ticket are correct
Spending limit is not available anymore for replacement tx
Tx with nonce 0 can be rejected/replaced
The flicker effect doesn't happen anymore.

Issue: Now that I can replace tx with nonce 0 I noticed this:

In adv options and having only the tx with nonce 0 available for replacement, if you click on the nonce field to see the list of nonces you can replace it shows no list. It would be expected to show the list with only the nonce 0 tx.

How it is expected to behave:

[schmanu]

I'm still puzzled by Backdrop rendering but the workaround works :D

[iamacook]

Now that I can replace tx with nonce 0 I noticed this:

This should now work:

I've also included your findings from the epic here as the PR is still open.

Once you create a rejection and Queue it, the "replace" button is gone, even tho it should be reasonalble to replace even the rejection. (probably the replace button is just following the logic of the old reject button)
What shouldn't be available anymore is the "Reject button" in the "Replace tx modal". The button could be grayed out the tooltip saying "this nonce already has a rejection proposed"

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.