fix: handle nullable SafeInfo['version']
#1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://invalidsafeversion--webcore.review-web-core.5afe.dev |
katspaugh
approved these changes
Dec 9, 2022
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Could you also add "unsupported contract" here instead of an empty version?
|
|
Looks good, the link is empty tho (no href).
|
I've recitified this.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This cannot be merged until safe-global/safe-gateway-typescript-sdk#108 is merged/released and a new lock is generated.
What it solves
Resolves #1327
How this PR fixes it
The nullable
SafeInfo['version']for unsupported base contracts is now handled.How to test it
Open
matic:0xF3aa45696f8Bc702D41d11b365C067f26f79fcaAand open the module settings. Observe no error/app crash.