Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to "Contract interaction" for module #1301

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 1, 2022

What it solves

Resolves #1297

How this PR fixes it

"Contract interaction" is used as a fallback for unknown module interactions.

How to test it

Open eth:0x0DA0C3e52C977Ed3cBc641fF02DD271c3ED55aFe/transactions/tx?id=module_0x0DA0C3e52C977Ed3cBc641fF02DD271c3ED55aFe_0xe14278097fc7d0f462d2913d36185505ee09f8476ac899620c409eb0afaa812a_0xa65aaf534f1a4620 on production and observe the type be "Contract interaction".

Screenshots

image

@iamacook iamacook requested a review from usame-algan December 1, 2022 16:59
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Branch preview

✅ Deploy successful!

https://module-tx-fallback--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit 567b88b into dev Dec 6, 2022
@iamacook iamacook deleted the module-tx-fallback branch December 6, 2022 12:06
@katspaugh katspaugh mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module tx is marked as settings tx and doesn't have title
4 participants