feat: replace specific transactions #1053
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
7aa89fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a2bfe51.web-core.pages.dev |
| Branch Preview URL: | https://replace-nonce.web-core.pages.dev |
|
Design-wise, "Rejection transaction" could also be just grey, not red, and say "Empty transaction"? Might be more transparent to the user. |
| @@ -42,7 +44,7 @@ const RejectTxButton = ({ | |||
| <> | |||
| <Track {...TX_LIST_EVENTS.REJECT}> | |||
| {compact ? ( | |||
| <Tooltip title="Reject" arrow placement="top"> | |||
| <Tooltip title="Replace" arrow placement="top"> | |||
| <span> | |||
| <IconButton onClick={onClick} color="error" size="small" disabled={isDisabled}> | |||
| <SvgIcon component={ErrorIcon} inheritViewBox fontSize="small" /> | |||
There was a problem hiding this comment.
I feel like the ErrorIcon does not capture the replacement feature as much as it did the rejection.
There was a problem hiding this comment.
@johannesmoormann mentioned that we will work on these designs some more so I think we can revisit this at a later stage.
| return ( | ||
| <> | ||
| <ModalDialog open dialogTitle="New transaction" onClose={onClose}> | ||
| <ModalDialog open dialogTitle={dialogTitle} onClose={onClose}> | ||
| <DialogContent> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap={2} pt={7} pb={4} width={240} m="auto"> |
There was a problem hiding this comment.
Should we add some info-text here if the nonce is set explaining how replacement works?
Something along the lines of Replacing a transaction will create a transaction with the same nonce. To actually replace / reject this new transaction has to get executed to use that nonce
There was a problem hiding this comment.
It looked somewhat odd with text inside the modal. I've added a tooltip. What do you think?
I much prefer the wording. I've adjusted the
"Contract interaction" for reference:
|
|
I will merge this into the epic branch. |
* feat: replace specific transactions (#1053) * feat: replace specific transactions * fix: cleanup code * fix: update title * style: change `variant` * fix: replacing `0` nonced transactions * feat: add autocomplete to `NonceForm` nonce (#1059) * feat: replacement modal (#1132) * feat: replace transaction modal w/ stepper * fix: adjust text + padding/margins * fix: adjust alignment + add mobile view * fix: alignment * fix: tweak autocomplete item text * fix: shorten text + add `Backdrop` * Merge branch 'dev' into tx-replacement * fix: replace nonce 0, flicker, no spending limit + disable duplite rejections (#1300) * fix: replace nonce 0, flicker + no spending limit * fix: always allow replacement + nonce `0` * fix: remove tag * Rm backdrop Co-authored-by: katspaugh <[email protected]> Co-authored-by: katspaugh <[email protected]>
What it solves
Resolves #972
How this PR fixes it
Clicking "Replace" now opens the transaction creation modal in "replacement mode". It is possible to create an asset/NFT transfer with the nonce of the chosen transaction, or alternatively a rejection transaction.
How to test it
Queue a transaction then click "Replace". Observe that the transaction-to-be-created will be of the same nonce as that which will be replaced.
Analytics changes
Clicking "Rejection transaction" in the creation modal emits:
Screenshots
Note: the button style has changed since recording this GIF.
New variant: