Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust text of buttons in transfer modal #1342

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 9, 2022

What it solves

Mixture of nouns and verbs in the transfer modal.

How this PR fixes it

The "Contract interaction" text has been changed to "Build transaction" and the title of the replacement button area to "Select how you would like to replace this transaction" in order to match the semantics of the buttons that are all now titled with verbs ("Rejection transaction" is now "Reject transaction").

How to test it

  1. Open the new transaction modal either by the sidebar or transaction replacement.
  2. Observe the new text.

Screenshots

image

image

@iamacook iamacook requested a review from katspaugh December 9, 2022 14:53
@iamacook iamacook self-assigned this Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Branch preview

⏳ Deploying a preview site...

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new tx modal, verbs were better imho, more actionable. But it’s OK since it’s the same component.

@katspaugh katspaugh merged commit 1229ef1 into dev Dec 12, 2022
@katspaugh katspaugh deleted the replacement-button-text branch December 12, 2022 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants