Tpetra: Removal of deprecated code meta issue #5602

tjfulle · 2019-07-30T20:58:55Z

tjfulle · 2019-07-30T21:00:06Z

Status for `GlobalOrdinal=int`, `LocalOrdinal=int`

Configuration and Build

Note: the branch tjfulle:issue-5536 is being updated with this issue, the configuration below is known to build with this branch. Build errors are likely on trilinos:develop

Note: the configuration below is being updated as issues are resolved.

With deprecated code disabled and using the default Tpetra GlobalOrdinal, the
build fails due to inconsistencies between Tpetra's global ordinal and Epetra.
For instance, Xpetra fails to build because it requires that Tpetra's global
ordinal be int when Epetra is enabled. The solution is to disable Epetra
support in this and other packages, or set the global ordinal to int, as in
the configuration below.

Note, the configuration options file below requires that
${TRILINOS_DIR}/cmake/std/sems/PullRequestGCC7.3.0TestingEnv.sh be sourced.

#!/bin/sh
rm -rf CMake*
  cmake
  -G "Ninja" \
  -D Trilinos_ENABLE_Tpetra:BOOL=ON \
  -D Tpetra_INST_INT_INT:BOOL=ON \
  -D Trilinos_CONFIGURE_OPTIONS_FILE:FILEPATH=${TRILINOS_DIR}/cmake/std/PullRequestLinuxCommonTestingSettings.cmake \
  -DTpetra_ENABLE_DEPRECATED_CODE:BOOL=OFF \
  -DXpetra_ENABLE_DEPRECATED_CODE:BOOL=OFF \
  -D Trilinos_ENABLE_STK:BOOL=OFF \
  -D ROL_ENABLE_EXAMPLES:BOOL=OFF \
  ${TRILINOS_DIR}

Failing tests

tjfulle · 2019-07-30T21:03:17Z

Status with `GlobalOrdinal=<default>` and `LocalOrdinal=<default>`

Configuration and Build

Note: the branch tjfulle:issue-5536 is being updated with this issue, the configuration below is known to build with this branch. Build errors are likely on trilinos:develop

Note: the configuration below is being updated as issues are resolved.

Like the previous comment, with deprecated code disabled, all downstream packages enabled, and using the default Tpetra GlobalOrdinal, the build fails for a variety of reasons. Many packages need to be disabled to get a build to completion.

Note, the configuration options file below requires that
${TRILINOS_DIR}/cmake/std/sems/PullRequestGCC7.3.0TestingEnv.sh be sourced.

Final (Working) Configuration

/projects/sems/install/rhel6-x86_64/sems/utility/cmake/3.12.2/bin/cmake \
  -G "Ninja" \
  -D Trilinos_CONFIGURE_OPTIONS_FILE:FILEPATH=$TRILINOS_DIR/cmake/std/PullRequestLinuxCommonTestingSettings.cmake \
  -D Trilinos_ENABLE_Tpetra:BOOL=ON \
  -D Trilinos_ENABLE_Epetra:BOOL=OFF \
  -D Trilinos_ENABLE_Moertel:BOOL=OFF \
  -D Trilinos_ENABLE_ShyLU_DDFROSch:BOOL=OFF \
  -D Trilinos_ENABLE_Stokhos:BOOL=OFF \
  -D ROL_ENABLE_EXAMPLES:BOOL=OFF \
  -D Tpetra_ENABLE_DEPRECATED_CODE:BOOL=OFF \
  -D Xpetra_ENABLE_DEPRECATED_CODE:BOOL=OFF \
  -D Rythmos_ENABLE_TESTS:BOOL=OFF \
  -D Trilinos_ENABLE_FEI:BOOL=OFF \
  -D Trilinos_ENABLE_Panzer:BOOL=OFF \
 $TRILINOS_DIR

Failing Tests

Closes: trilinos#5594 Related: trilinos#5602

brian-kelley · 2019-08-02T00:06:35Z

@tjfulle I fixed the Ifpack2_AdditiveSchwarz_MPI_4 tests, and made a pull request into your branch "issue-5536". Is that the right way to merge it, or should I PR straight to origin/develop?

tjfulle#2

Edit: nvm, closed that one, I'll wait until #5590 gets merged and then make a PR in the main repo.
Edit2: This is in #5640, which will be merged when autotesting finishes.

mhoemmen · 2019-08-02T16:55:18Z

PR #5573 merged, so Stokhos builds now with Tpetra deprecated code OFF and GO=int OFF.

GeoffDanielson · 2019-08-02T19:55:10Z

@tjfulle , I am unable to make Belos_resolve_gmres_hb_1_MPI_4 fail with GO = LO = int

GeoffDanielson · 2019-08-02T20:21:56Z

@tjfulle I am also unable to make Rythmos_IntegratorBuilder_ConvergenceTest_MPI_1 fail with GO = LO = int.

kddevin · 2019-08-02T20:52:52Z

@tjfulle I am running tempus now, but not seeing failures in some of the tests that were reported as failures. Perhaps the rebase from develop pulled in solutions.

I will report all tempus results once them run to completion; the tempus tests take a long time on my workstation.

Zoltan2 fixes are in PR #5645 and will soon be merged with develop (I hope).

Closes: #5749 Part of: #5602

Closes: #5754 Part of: #5602

* Zoltan2: use ZOLTAN2_HAVE_EPETRA. Closes: #5751 Part of: #5602 * only disable epetra in zoltan2 if user explicitly requested * some versions of cmake did not like the last conditional

kddevin · 2019-08-26T16:36:38Z

Hey, @tjfulle : what's the current status? If needed, we can ask @DrBooom to help with remaining failures.

tjfulle · 2019-08-26T16:44:24Z

I’ll gather more details, off the top of my head, some ROL examples and MueLu tests fail with deprecated code off and default ordinals in Tpetra. A large remaining issue is that this is with Epetra disabled. I’m not sure many apps are ready to fully abandon Epetra (@trilinos/panzer for example). With Tpetra_INST_INT_INT=ON there are other failures I haven’t looked at since the initial diagnostic (and might now be better with the many PRs for this issue).

If @DrBooom can look in to test failures with deprecated code off and Tpetra_INST_INT_INT=ON, I’ll start looking in to being able to enable Epetra when Tpetra ordinals are their default values

rppawlo · 2019-08-26T17:22:29Z

Right now, panzer requires both epetra and tpetra but can use any single GO that is enabled in tpetra, so it should not hold things up. If the GO is not appropriate for Epetra, the workaround for ATDM builds is to disable epetra support in the xpetra and muelu packages.Then both stacks build with any tpetra GO type. I'll be making the panzer requirement on epetra optional early next FY. Ross has an ATDM build running nightly that enables a single GO (long long) and builds the entire stack including panzer, epetra and tpetra. If there is anything on the panzer side you encounter, please let me know, but I think we are clear on the deprecated tpetra code.

tjfulle · 2019-08-26T17:38:28Z

Thanks @rppawlo, I don’t think Panzer is a hold up. I’ll have to look at the ATDM config. My definition of done is to enable Tpetra+ALL downstream packages with deprecated code off and otherwise the standard PR config. Perhaps this config enables more than ATDM and that’s the source of the failures? We’re getting to the bottom of it...

brian-kelley · 2019-09-26T18:27:12Z

There are now 4 nightly builds with deprecated off:

GO=int. Currently, one Xpetra test failure and a bunch of STK build errors because it wants GO=long long.
GO=long long. Because Epetra32 is on, Xpetra has a config error saying that Tpetra must also have GO=int enabled. There are also several build errors in ROL, TrilinosCouplings and Piro.
GO=long long, no Epetra and no ETI: clean.
Basic build with just Tpetra/Epetra, GO=long long: clean.

@tjfulle If you're not already working on these, I can look at the ROL build errors in GO long long today and tomorrow.

…c profile. Dynamic profile construction is deprecated. Added loops to count number of entries per row to be inserted into graph. See github #5602

the number of nonzeros per row in this case is constant for each row.

… profile

panzer: change dynamic profile Tpetra::CrsGraph construction to static profile for #5602

…s:develop' (8fe9e32). * trilinos-develop: TrilinosCouplings: fixed wrong type in BlockRelaxation paramlist MueLu: remerge separate libraries Fixed shadow warning Use XHOSTTYPE Windows to skip tests on windows EXODUS: Fix for loop Automatic snapshot commit from seacas at cd7b73e53c Tempus: Add Output Control to TimeStepControl. panzer: trilinos#5602 changed dynamic profile CrsGraph construction to static profile panzer: an easy fix from dynamic profile to static profile trilinos#5602 the number of nonzeros per row in this case is constant for each row. panzer: change dynamic profile Tpetra::CrsGraph construction to static profile. Dynamic profile construction is deprecated. Added loops to count number of entries per row to be inserted into graph. See github trilinos#5602 IOSS: A couple pamgen fixes (test and compilation warning) Automatic snapshot commit from seacas at 83f74bc141

github-actions · 2021-09-25T12:25:28Z

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

github-actions · 2021-12-01T12:26:52Z

This issue was closed due to inactivity for 395 days.

tjfulle added type: bug The primary issue is a bug in Trilinos code or tests pkg: Tpetra TpetraRF labels Jul 30, 2019

tjfulle added this to the Tpetra: Deprecate DynamicProfile milestone Jul 30, 2019

lucbv mentioned this issue Jul 30, 2019

Galeri: fix for issue #5593, protecting Epetra only examples in CMakeLists.txt #5600

Merged

9 tasks

tjfulle mentioned this issue Jul 30, 2019

Tpetra: Build errors with deprecated code off #5536

Closed

tjfulle added a commit to tjfulle/Trilinos that referenced this issue Jul 30, 2019

FEI: make Epetra a required dependency

2748903

Closes: trilinos#5594 Related: trilinos#5602

lucbv mentioned this issue Aug 1, 2019

MueLu: fixing the number of non-zeros per row in unsmoosh factory #5628

Merged

9 tasks

tjfulle mentioned this issue Aug 1, 2019

MueLu: tests fail to build if Galeri is disabled #5595

Closed

lucbv mentioned this issue Aug 1, 2019

MueLu: fixing isorropia test before removal of Tpetra deprecated code issue #5614 #5631

Merged

9 tasks

GeoffDanielson mentioned this issue Aug 2, 2019

Fix Amesos2 unit tests KLU2 and GappedMtxGIDs #5641

Merged

2 tasks

kddevin added a commit that referenced this issue Aug 2, 2019

zoltan2: changes to allow deprecation of dynamicProfile #5602

cdd75cd

brian-kelley mentioned this issue Aug 2, 2019

ShyLU: Fixed test link errors #5618 #5650

Merged

9 tasks

kddevin added a commit that referenced this issue Aug 2, 2019

teko: fixes to support staticProfile matrix construction in Tpetra #5602

afa0c9f

kddevin mentioned this issue Aug 3, 2019

teko: fixes to support staticProfile matrix construction in Tpetra #5602 #5651

Merged

tjfulle added a commit that referenced this issue Aug 19, 2019

Xpetra: remove Tpetra deprecated code (#5750)

e3f7b43

Closes: #5749 Part of: #5602

tjfulle added a commit that referenced this issue Aug 20, 2019

Trilinos Couplings: Fix for #5754 (#5755)

71ace56

Closes: #5754 Part of: #5602

tjfulle mentioned this issue Aug 20, 2019

Deal with depracation of DynamicProfile option for Tpetra::CrsGraph constructor sandialabs/Albany#442

Closed

This was referenced Oct 4, 2019

Xpetra: Fix default builds with deprecated OFF #6045

Merged

ShyLU_DDFrosch: fix Epetra enable logic in test cmake #6060

Merged

Xpetra: disable Map cloner test if no Tpetra deprecated #6064

Merged

kddevin added a commit that referenced this issue Oct 9, 2019

panzer: change dynamic profile Tpetra::CrsGraph construction to stati…

9b68f90

…c profile. Dynamic profile construction is deprecated. Added loops to count number of entries per row to be inserted into graph. See github #5602

kddevin added a commit that referenced this issue Oct 9, 2019

panzer: an easy fix from dynamic profile to static profile #5602

8bf6aa6

the number of nonzeros per row in this case is constant for each row.

kddevin added a commit that referenced this issue Oct 9, 2019

panzer: #5602 changed dynamic profile CrsGraph construction to static…

2233464

… profile

kddevin mentioned this issue Oct 9, 2019

panzer: change dynamic profile Tpetra::CrsGraph construction to static profile for #5602 #6068

Merged

rppawlo added a commit that referenced this issue Oct 15, 2019

Merge pull request #6068 from trilinos/panzer_staticprofile

a133adb

panzer: change dynamic profile Tpetra::CrsGraph construction to static profile for #5602

brian-kelley mentioned this issue Oct 15, 2019

TrilinosCouplings: fixed wrong type in BlockRelaxation paramlist #6101

Merged

kddevin mentioned this issue Oct 15, 2019

STK: fix for #5541 Detect insufficient global ordinal type at configure rather than build time #6102

Merged

This was referenced Nov 19, 2019

Panzer/Tpetra: Export from ghosted graph to empty graph reports insufficient capacity #6163

Closed

Ifpack2: Better handling of StaticProfile graph construction in RILUK #6340

Merged

brian-kelley mentioned this issue Dec 3, 2019

Tpetra/MueLu/Ifpack2/Xpetra: remove all deprecated code (including DynamicProfile) #6388

Merged

kddevin mentioned this issue Dec 5, 2019

Zoltan2: allow test using zoltan to pass with default long long global_ordinal type #6400

Merged

github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Sep 25, 2021

github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Dec 1, 2021

github-actions bot closed this as completed Dec 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tpetra: Removal of deprecated code meta issue #5602

Tpetra: Removal of deprecated code meta issue #5602

tjfulle commented Jul 30, 2019 •

edited by kddevin

Loading

tjfulle commented Jul 30, 2019 •

edited by GeoffDanielson

Loading

tjfulle commented Jul 30, 2019 •

edited

Loading

brian-kelley commented Aug 2, 2019 •

edited

Loading

mhoemmen commented Aug 2, 2019

GeoffDanielson commented Aug 2, 2019 •

edited

Loading

GeoffDanielson commented Aug 2, 2019 •

edited

Loading

kddevin commented Aug 2, 2019

kddevin commented Aug 26, 2019

tjfulle commented Aug 26, 2019 •

edited

Loading

rppawlo commented Aug 26, 2019

tjfulle commented Aug 26, 2019

brian-kelley commented Sep 26, 2019 •

edited

Loading

github-actions bot commented Sep 25, 2021

github-actions bot commented Dec 1, 2021

Tpetra: Removal of deprecated code meta issue #5602

Tpetra: Removal of deprecated code meta issue #5602

Comments

tjfulle commented Jul 30, 2019 • edited by kddevin Loading

Bug Report

Description

tjfulle commented Jul 30, 2019 • edited by GeoffDanielson Loading

Status for GlobalOrdinal=int, LocalOrdinal=int

Configuration and Build

Failing tests

tjfulle commented Jul 30, 2019 • edited Loading

Status with GlobalOrdinal=<default> and LocalOrdinal=<default>

Configuration and Build

Final (Working) Configuration

Failing Tests

brian-kelley commented Aug 2, 2019 • edited Loading

mhoemmen commented Aug 2, 2019

GeoffDanielson commented Aug 2, 2019 • edited Loading

GeoffDanielson commented Aug 2, 2019 • edited Loading

kddevin commented Aug 2, 2019

kddevin commented Aug 26, 2019

tjfulle commented Aug 26, 2019 • edited Loading

rppawlo commented Aug 26, 2019

tjfulle commented Aug 26, 2019

brian-kelley commented Sep 26, 2019 • edited Loading

github-actions bot commented Sep 25, 2021

github-actions bot commented Dec 1, 2021

tjfulle commented Jul 30, 2019 •

edited by kddevin

Loading

tjfulle commented Jul 30, 2019 •

edited by GeoffDanielson

Loading

Status for `GlobalOrdinal=int`, `LocalOrdinal=int`

tjfulle commented Jul 30, 2019 •

edited

Loading

Status with `GlobalOrdinal=<default>` and `LocalOrdinal=<default>`

brian-kelley commented Aug 2, 2019 •

edited

Loading

GeoffDanielson commented Aug 2, 2019 •

edited

Loading

GeoffDanielson commented Aug 2, 2019 •

edited

Loading

tjfulle commented Aug 26, 2019 •

edited

Loading

brian-kelley commented Sep 26, 2019 •

edited

Loading