Xpetra: inconsistent declaration of TpetraMap::clone

[tjfulle]

Bug Report

@trilinos/xpetra

Description

The deprecated Xpetra::TpetraMap<>::clone is declared in xpetra/src/Map/Xpetra_TpetraMap_decl.hpp guarded by #ifdef XPETRA_ENABLE_DEPRECATED_CODE but defined in xpetra/src/Map/Xpetra_TpetraMap_def.hpp guarded by #ifdef TPETRA_ENABLE_DEPRECATED_CODE. The clone method is later called in packages/xpetra/sup/Cloner/Xpetra_Cloner.hpp but is guarded only by #ifdef XPETRA_HAVE_TPETRA. The inconsistency causes build errors (#5536).

I have a potential fix building right now. It

• replaces #ifdef XPETRA_ENABLE_DEPRECATED_CODE in xpetra/src/Map/Xpetra_TpetraMap_decl.hpp with #ifdef TPETRA_ENABLE_DEPRECATED_CODE
• replaces #ifdef XPETRA_HAVE_TPETRA in packages/xpetra/sup/Cloner/Xpetra_Cloner.hpp with #if defined(XPETRA_HAVE_TPETRA) && defined(TPETRA_ENABLE_DEPRECATED_CODE)

The build seems to get by this error but fails at MueLu now...

[jhux2]

@william76 is this something you could have a look at?

_{Sent with GitHawk}

[tjfulle]

@jhux2, I have a whole bevy of fixes for building with/without Tpetra deprecated code, including a fix for this.

[tjfulle]

This should be closed by #5750

[william76]

@tjfulle Just checking in, was this issue ever fixed?

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions]

This issue was closed due to inactivity for 395 days.