Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xpetra: remove Tpetra deprecated code #5750

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Xpetra: remove Tpetra deprecated code #5750

merged 1 commit into from
Aug 19, 2019

Conversation

tjfulle
Copy link
Contributor

@tjfulle tjfulle commented Aug 19, 2019

Closes: #5749
Part of: #5602

Rather than compile out the call to Tpetra::Map::clone, perhaps a deep copy should be made instead?

@tjfulle tjfulle requested a review from jhux2 August 19, 2019 14:26
@tjfulle tjfulle changed the base branch from master to develop August 19, 2019 14:26
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4293
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4115
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2554
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2378
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1955
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 415
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 415
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Using Repos:

Repo: TRILINOS (tjfulle/Trilinos)
  • Branch: issue-5749
  • SHA: d19f34c
  • Mode: TEST_REPO

Pull Request Author: tjfulle

@tjfulle tjfulle mentioned this pull request Aug 19, 2019
Closed
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4293
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4115
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2554
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2378
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1955
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 415
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 415
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5750
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH issue-5749
TRILINOS_SOURCE_REPO https://github.com/tjfulle/Trilinos
TRILINOS_SOURCE_SHA d19f34c
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e08ac1c


CDash Test Results for PR# 5750.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@tjfulle tjfulle merged commit e3f7b43 into trilinos:develop Aug 19, 2019
@tjfulle tjfulle deleted the issue-5749 branch August 19, 2019 20:02
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Aug 20, 2019
Merge 'trilinos/Trilinos:develop' (4ac3b93) into 'tcad-charon/Trilino…
710187f 
…s:develop' (12eb4be).

* trilinos-develop: (24 commits)
  Piro: fix Tpetra ordinal issues. (trilinos#5747)
  Trilinos Couplings: Fix for trilinos#5754 (trilinos#5755)
  Xpetra: remove Tpetra deprecated code (trilinos#5750)
  Xpetra: MapFactory - ETI - Update (PR trilinos#5723)
  Panzer: require Epetra to build
  Stokhos: fix for trilinos#5742 (trilinos#5743)
  Amesos2: Fix test for throw to work on MPI
  Panzer: consistent ordinals
  Xpetra: MapFactory - ETI - branch testing & checkpoint 2019-08-17 (v002)
  Xpetra: MapFactory - ETI - branch testing & checkpoint 2019-08-17
  Phalanx/Panzer: deprecate some utilities
  Phalanx: adding memory manager
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-16
  Phalanx: split out print from extent traits
  Phalanx: add field use range computation
  Xpetra: ETI - MapFactory - Merging with develop
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-15
  Xpetra: MapFactory - ETI - branch checkpoint
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-13
  Xpetra: ETI MapFactory
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Aug 20, 2019
Merge 'trilinos/Trilinos:develop' (4ac3b93) into 'tcad-charon/Trilino…
f3f47c8 
…s:develop' (12eb4be).

* trilinos-develop: (24 commits)
  Piro: fix Tpetra ordinal issues. (trilinos#5747)
  Trilinos Couplings: Fix for trilinos#5754 (trilinos#5755)
  Xpetra: remove Tpetra deprecated code (trilinos#5750)
  Xpetra: MapFactory - ETI - Update (PR trilinos#5723)
  Panzer: require Epetra to build
  Stokhos: fix for trilinos#5742 (trilinos#5743)
  Amesos2: Fix test for throw to work on MPI
  Panzer: consistent ordinals
  Xpetra: MapFactory - ETI - branch testing & checkpoint 2019-08-17 (v002)
  Xpetra: MapFactory - ETI - branch testing & checkpoint 2019-08-17
  Phalanx/Panzer: deprecate some utilities
  Phalanx: adding memory manager
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-16
  Phalanx: split out print from extent traits
  Phalanx: add field use range computation
  Xpetra: ETI - MapFactory - Merging with develop
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-15
  Xpetra: MapFactory - ETI - branch checkpoint
  Xpetra: MapFactory - ETI - branch checkpoint 2019-08-13
  Xpetra: ETI MapFactory
  ...
searhein pushed a commit to searhein/Trilinos that referenced this pull request Aug 20, 2019
Merge branch 'develop' of https://github.com/trilinos/Trilinos into f…
5e14cae 
…rosch-albany

* 'develop' of https://github.com/trilinos/Trilinos: (138 commits)
  IOSS: Serialize IO test only with parallel-aware exodus
  Amesos2: Count entries in matrix before allocating (trilinos#5745)
  Piro: fix Tpetra ordinal issues. (trilinos#5747)
  Trilinos Couplings: Fix for trilinos#5754 (trilinos#5755)
  Tpetra: Fix trilinos#5762
  Ctest: Fixing missing space
  Ctest: geminga test updates
  Xpetra: remove Tpetra deprecated code (trilinos#5750)
  Testing: change valgrind test days
  Xpetra: MapFactory - ETI - Update (PR trilinos#5723)
  Automatic snapshot commit from seacas at e6496d0cc0
  Fix smart-jenkins-driver.sh (trilinos#4933)
  KokkosKernels: CUDA SPGEMM symbolic workaround
  MueLu RefMaxwell: Allow setting importer parameters
  MueLu: Allow setting distributor parameters at end of setup
  Xpetra: Allow setting parameters on Distributor of Import/Export
  Xpetra::ImportFactory: Add optional parameter list
  Panzer: require Epetra to build
  MueLu: add some braces to region MG smoothers
  Stokhos: fix for trilinos#5742 (trilinos#5743)
  ...

# Conflicts:
#	packages/shylu/shylu_dd/frosch/cmake/Dependencies.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csiefer2 csiefer2 csiefer2 approved these changes

@jhux2 jhux2 Awaiting requested review from jhux2

Assignees
No one assigned
Labels
pkg: Xpetra TpetraRF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjfulle @trilinos-autotester @csiefer2