teko: fixes to support staticProfile matrix construction in Tpetra #5602 #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddevin
added
pkg: Teko
AT: AUTOMERGE
14 tasks
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
rppawlo
approved these changes
Aug 5, 2019
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 5651: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
mhoemmen
reviewed
Aug 5, 2019
| size_t numEntries = -1; | ||
| GO globalRow = gRowMap->getGlobalElement(localRow); | ||
| LO lid = A->getRowMap()->getLocalElement(globalRow); | ||
| TEUCHOS_ASSERT(lid>-1); |
There was a problem hiding this comment.
In the future, it's nicer to use the flag value Teuchos::OrdinalTraits<LO>::invalid().
ndellingwood
added a commit
that referenced
this pull request
Dec 12, 2022
…908df1 From repository at [email protected]:kokkos/kokkos.git At commit: commit 90b7c0964935aa71ae50446ae8a9d433af908df1 Author: Christian Trott <[email protected]> Date: Wed Dec 7 21:46:47 2022 -0700 Merge pull request #5671 from crtrott/fix-5651 Fix #5651: Intel Classic Compiler ICE (cherry picked from commit d24d7ed40574147c7f7d80414d9f1554f4ac3379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5602
@trilinos/teko
Description
Changes to enable only static profile construction of Tpetra CrsMatrices.
Enables builds with Tpetra_ENABLE_DEPRECATED_CODE=OFF to succeed.
Changed one test to provide a maximum number of entries per row. (Note that this test is rather odd in that it inserts into one matrix row twice, while not inserting at all into another matrix row. But I digress.)
Changed the subblock constructor to count the number of nonzeros per row, then create the matrix, and then insert the nonzeros.
Motivation and Context
DynamicProfile construction of Tpetra CrsGraph and CrsMAtrix is deprecated and will disappear soon.
Tested on linux with
Tpetra_ENABLE_DEPRECATED_CODE=OFF
Xpetra_ENABLE_DEPRECATED_CODE=OFF
Tpetra_INST_INT_INT=ON