Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrilinosCouplings: fixed wrong type in BlockRelaxation paramlist #6101

Merged
merged 1 commit into from
Oct 15, 2019
Merged

TrilinosCouplings: fixed wrong type in BlockRelaxation paramlist #6101

merged 1 commit into from
Oct 15, 2019

Conversation

brian-kelley
Copy link
Contributor

@brian-kelley brian-kelley commented Oct 15, 2019 •
edited by jhux2
Loading

"partitioner: map" should always be ArrayRCP<int>, not
ArrayRCP<GlobalOrdinal> (this is OK as the elements are local row IDs).

@trilinos/trilinoscouplings

Motivation

Fixes a test for GO=long long.

Related Issues

Stakeholder Feedback

Testing

Change just affects the test TrilinosCouplings_Poisson2D_pn=4_tpetra_MPI_1, which now passes with GO long long.

@brian-kelley
TrilinosCouplings: fixed wrong type in BlockRelaxation paramlist
55f5fb4 
"partitioner: map" should always be ArrayRCP<int>, not
ArrayRCP<GlobalOrdinal> (this is OK as the elements are local row IDs).
@brian-kelley brian-kelley added pkg: TrilinosCouplings impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Oct 15, 2019
@brian-kelley brian-kelley self-assigned this Oct 15, 2019
jhux2
jhux2 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jhux2 jhux2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4741
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4568
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2999
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2825
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2400
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 792
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 792
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Using Repos:

Repo: TRILINOS (brian-kelley/Trilinos)
  • Branch: FixTCouplings
  • SHA: 55f5fb4
  • Mode: TEST_REPO

Pull Request Author: brian-kelley

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4741
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4568
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2999
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2825
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2400
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 792
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 792
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6101
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH FixTCouplings
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 55f5fb4
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1907304


CDash Test Results for PR# 6101.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jhux2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 59bebf4 into trilinos:develop Oct 15, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 6101: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 15, 2019
@brian-kelley brian-kelley deleted the FixTCouplings branch October 15, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhux2 jhux2 jhux2 approved these changes

@tjfulle tjfulle Awaiting requested review from tjfulle

@GeoffDanielson GeoffDanielson Awaiting requested review from GeoffDanielson

Assignees

@brian-kelley brian-kelley

Labels
impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) pkg: TrilinosCouplings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-kelley @trilinos-autotester @jhux2