ROL: Use of deprecated Tpetra code

[tjfulle]

Bug Report

@trilinos/rol

Relates to: #5536

Description

Several of ROL's examples use the deprecated Tpetra::CrsMatrix<>::getNode and clone methods:

$ cd packages/rol/example
$ grep -irn 'getNode(' .
./PDE-OPT/0ld/TOOLS/PDE_FEM.hpp:669:    //ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/TOOLS/PDE_FEM.hpp:723://    //ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/adv-diff-react/data.hpp:532:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/poisson/data.hpp:453:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/stefan-boltzmann/data.hpp:475:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/stefan-boltzmann/data.hpp:734:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/stoch-adv-diff/data.hpp:605:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
./PDE-OPT/0ld/stoch-adv-diff/data.hpp:808:    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();

[tjfulle]

getNode is only used to cal (the deprecated) Tpetra::CrsMatrix<>::clone. clone appears to be used to make a deep copy of the matrix. The following diff gets around the compile error:

-    ROL::Ptr<Tpetra::Details::DefaultTypes::node_type> node = matA_->getNode();
-    matA_dirichlet_ = matA_->clone(node);
+    matA_dirichlet_ = ROL::makePtr<Tpetra::CrsMatrix<>>(*matA_, Teuchos::DataAccess::Copy);

apply this (or similar) everywhere clone is called.

[kyungjoo-kim]

@tjfulle I just compiled the code with deprecated off and inst int int ON. It compiled ROL examples and tests. Could you give me a more specific Tpetra configuration ? I tested the default one too but it does not cause a compile problem.

[kyungjoo-kim]

Do I need to turn on warning as an error ?

[tjfulle]

@kyngjoo-kim, see #5602 (comment) for the config. It could be that this has already been fixed by the ROL developers?

[tjfulle]

@kyungjoo-kim note, the config linked in the last comment disables ROL's examples, you would need to remove that line.

[kyungjoo-kim]

@tjfulle now I see some errors..

[kyungjoo-kim]

Hi @tjfulle I pushed into the issue-5536 branch. At least it compiles with deprecation code off. I also found that you already finish all changes related to getNode and clone. My fix is on the mismatch between local use of int type and Tpetra global ordinal type. Please double check if ROL compiles as I can see on "white".

[tjfulle]

closed by #5739