ROL: fix for Tpetra_DEPRECATED_CODE=OFF #5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit mostly fixes the problem due to mismatch between Tpetra global ordinal type and "int" used in ROL examples.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: tjfulle |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 4288 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 4110 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 2549 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 2373 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 1950 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 412 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 412 (click to expand) |
|
Related to #5540 |
dridzal
previously approved these changes
Aug 19, 2019
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: tjfulle |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 4300 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 4122 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 2561 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 2385 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 1962 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 422 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 422 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: tjfulle |
mhoemmen
approved these changes
Aug 20, 2019
| @@ -52,7 +52,7 @@ namespace ROL { | |||
| template<class Real, class Ordinal> | |||
There was a problem hiding this comment.
Does Ordinal only get used for Comm?
| } | ||
|
|
||
| void reduceAll(Real* input, Real* output, int dim, | ||
| const Elementwise::ReductionOp<Real> &r) { | ||
| int nB = this->numBatches(); | ||
| std::vector<Real> receiveBuffer(nB); | ||
| Teuchos::gather<Ordinal,Real>(input,1,&receiveBuffer[0],1,0,*comm_); | ||
| Teuchos::gather<int,Real>(input,1,&receiveBuffer[0],1,0,*comm_); |
There was a problem hiding this comment.
ROL devs should start using data() instead of &vec[0] : - )
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
This was referenced Aug 20, 2019
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 21, 2019
…s:develop' (f3f47c8). * trilinos-develop: Zoltan2: use ZOLTAN2_HAVE_EPETRA. (trilinos#5752) Testing: geminga: update valgrind version ShuLU: fix for trilinos#5538 (trilinos#5748) ROL: fix for Tpetra_DEPRECATED_CODE=OFF (trilinos#5739) IOSS: Serialize IO test only with parallel-aware exodus Amesos2: Count entries in matrix before allocating (trilinos#5745) Tpetra: Fix trilinos#5762 Ctest: Fixing missing space Ctest: geminga test updates Testing: change valgrind test days Automatic snapshot commit from seacas at e6496d0cc0 Fix smart-jenkins-driver.sh (trilinos#4933) KokkosKernels: CUDA SPGEMM symbolic workaround MueLu RefMaxwell: Allow setting importer parameters MueLu: Allow setting distributor parameters at end of setup Xpetra: Allow setting parameters on Distributor of Import/Export Xpetra::ImportFactory: Add optional parameter list MueLu: add some braces to region MG smoothers MueLu: define list of valid region smoothers MueLu: unify setup of region relaxation smoothers
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 21, 2019
…s:develop' (f3f47c8). * trilinos-develop: Zoltan2: use ZOLTAN2_HAVE_EPETRA. (trilinos#5752) Testing: geminga: update valgrind version ShuLU: fix for trilinos#5538 (trilinos#5748) ROL: fix for Tpetra_DEPRECATED_CODE=OFF (trilinos#5739) IOSS: Serialize IO test only with parallel-aware exodus Amesos2: Count entries in matrix before allocating (trilinos#5745) Tpetra: Fix trilinos#5762 Ctest: Fixing missing space Ctest: geminga test updates Testing: change valgrind test days Automatic snapshot commit from seacas at e6496d0cc0 Fix smart-jenkins-driver.sh (trilinos#4933) KokkosKernels: CUDA SPGEMM symbolic workaround MueLu RefMaxwell: Allow setting importer parameters MueLu: Allow setting distributor parameters at end of setup Xpetra: Allow setting parameters on Distributor of Import/Export Xpetra::ImportFactory: Add optional parameter list MueLu: add some braces to region MG smoothers MueLu: define list of valid region smoothers MueLu: unify setup of region relaxation smoothers
searhein
pushed a commit
to searhein/Trilinos
that referenced
this pull request
Aug 23, 2019
…rosch-albany * 'develop' of https://github.com/trilinos/Trilinos: (33 commits) ShyLU/FROSch: include missing Teptra header Tpetra: change TSQR dependency to KokkosCore respond to Jim W's comments on PR 5668 Phalanx: fix debug build Ctest: Valgrind changes Ctest: Valgrind updates Xpetra: Clean up BlockedMap includes MueLu: set dofs/node for decoupled line smoothing Belos Thyra adapter: Use caching in inner products when using Tpetra Thyra VectorSpace: Add new method createCachedMembersView Teuchos: Add Teuchos_string.hpp to CMakeLists.txt Zoltan2: use ZOLTAN2_HAVE_EPETRA. (trilinos#5752) Testing: geminga: update valgrind version ShuLU: fix for trilinos#5538 (trilinos#5748) ROL: fix for Tpetra_DEPRECATED_CODE=OFF (trilinos#5739) Added a PATH when the mock for module is called Go back to loading python setup by hand. Manually merge paths (prepending the new section) Add python load on ride. Update OMPI_CC and OMPI_FC dynamically ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5738
Part of #5602