-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate tf2_geometry_msgs.h #418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it to tf2_geometry_msgs.hpp instead. Signed-off-by: Chris Lalancette <[email protected]>
This was referenced May 14, 2021
Merged
ahcorde
approved these changes
May 14, 2021
All right, CI is green, and I have approval on all 3 PRs. Going ahead and merging, thanks for the review! |
jacobperron
added a commit
to jacobperron/navigation2
that referenced
this pull request
May 19, 2021
tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418. tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416. Signed-off-by: Jacob Perron <[email protected]>
6 tasks
SteveMacenski
pushed a commit
to ros-navigation/navigation2
that referenced
this pull request
May 20, 2021
tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418. tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to jacobperron/image_pipeline
that referenced
this pull request
May 21, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
JWhitleyWork
pushed a commit
to ros-perception/image_pipeline
that referenced
this pull request
Jun 24, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to jacobperron/image_pipeline
that referenced
this pull request
Jun 28, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
ruffsl
pushed a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418. tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to ros-perception/image_pipeline
that referenced
this pull request
Jul 7, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
This was referenced Jul 7, 2021
clalancette
pushed a commit
to ros-perception/image_pipeline
that referenced
this pull request
Jul 7, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Should fix current warnings on the rolling branch. Signed-off-by: Jacob Perron <[email protected]>
JWhitleyWork
pushed a commit
to ros-perception/image_pipeline
that referenced
this pull request
Jul 22, 2021
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
JWhitleyWork
pushed a commit
to ros-perception/image_pipeline
that referenced
this pull request
Apr 14, 2022
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418 tf2_eigen.h was deprecated in ros2/geometry2#413 Signed-off-by: Jacob Perron <[email protected]>
87 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move it to tf2_geometry_msgs.hpp instead.
Signed-off-by: Chris Lalancette [email protected]
Note that this requires two PRs in other repositories: