Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repalce deprecated headers of tf2_sensor_msgs #2346

Closed
wants to merge 1 commit into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 18, 2021

Related PR

#2342

@wep21 wep21 mentioned this pull request May 18, 2021
@ruffsl
Copy link
Member

ruffsl commented May 18, 2021

We'll rerun CI tomorrow after the dockerhub image updates. That'll sort out the missing commits with colcon cache. I built the image manually first, so the image included commits from my PR that have since been squashed.

@wep21
Copy link
Contributor Author

wep21 commented May 18, 2021

Note: header of tf2_geometry_msgs should be fixed if geometry2 in docker is latest.
ros2/geometry2#418

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after Galactic branch off and release (assuming CI passes then)

@SteveMacenski
Copy link
Member

#2350 supercedes, it replaces all of the tf2 hpp files, not just 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants