Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated headers #2350

Merged

Conversation

jacobperron
Copy link
Contributor

@jacobperron jacobperron commented May 19, 2021

tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418.
tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416.

This PR overlaps with #2346, which replaces only tf2_sensor_msgs.h.

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418.
tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416.

Signed-off-by: Jacob Perron <[email protected]>
@SteveMacenski
Copy link
Member

Is this a pre or post galactic PR? (e.g. if I released to Galactic tomorrow, which is my plan, would merging this be the correct status for galactic or after galactic?)

@SteveMacenski SteveMacenski merged commit ac531a2 into ros-navigation:main May 20, 2021
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
tf2_geometry_msgs.h was replaced by tf2_geometry_msgs.hpp in ros2/geometry2#418.
tf2_sensor_msgs.h was replaced by tf2_sensor_msgs.hpp in ros2/geometry2#416.

Signed-off-by: Jacob Perron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants