Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated geometry2 headers #659

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Replace deprecated geometry2 headers #659

merged 1 commit into from
Jul 22, 2021

Conversation

jacobperron
Copy link
Contributor

tf2_geometry_msgs.h was deprecated in ros2/geometry2#418
tf2_eigen.h was deprecated in ros2/geometry2#413

Note, we might want to hold this PR until the referenced changes in geometry2 are released into Rolling.

@JWhitleyWork
Copy link
Collaborator

@jacobperron The intent of the ros2 branch is not to target Rolling, but the most current release (as of today, Galactic) to avoid users accidentally downloading a version that won't work unless they have a fully-unstable dev environment. Would you be in favor of setting up either a rolling branch or ros2-dev?

@jacobperron
Copy link
Contributor Author

@JWhitleyWork Yeah, a branch to target the latest development would be nice. rolling sounds good to me.

@jacobperron jacobperron mentioned this pull request May 25, 2021
Merged
2 tasks
@jacobperron
Copy link
Contributor Author

I've created a new rolling branch and opened a rosdistro PR to point the Rolling distribution there: ros/rosdistro#30016

@JWhitleyWork
Copy link
Collaborator

Thanks, @jacobperron! Sorry I didn't get around to it. I'm finally tring to thin out the PRs and issues here with help from folks at OR.

@jacobperron jacobperron mentioned this pull request Jun 23, 2021
Merged
@jacobperron jacobperron force-pushed the update_deprecated_headers branch from a293252 to 6b649d2 Compare June 28, 2021 23:23
@jacobperron jacobperron reopened this Jun 28, 2021
@jacobperron jacobperron changed the base branch from ros2 to rolling June 28, 2021 23:27
@jacobperron jacobperron reopened this Jun 28, 2021
@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

@jacobperron
Replace deprecated geometry2 headers
01e52c7 
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418
tf2_eigen.h was deprecated in ros2/geometry2#413

Signed-off-by: Jacob Perron <[email protected]>
@jacobperron
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron force-pushed the update_deprecated_headers branch from 39dbca5 to 01e52c7 Compare July 7, 2021 21:30
This was referenced Jul 7, 2021
Closed
Closed
@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Contributor Author

@JWhitleyWork CI is green now, can you take a look? I think this should unblock some other outstanding PRs for Rolling.

@jacobperron
Copy link
Contributor Author

@JWhitleyWork Friendly ping 🙂

@JWhitleyWork
Copy link
Collaborator

Sorry for the delay. GTG.

@JWhitleyWork JWhitleyWork merged commit 31a63bf into ros-perception:rolling Jul 22, 2021
@jacobperron jacobperron deleted the update_deprecated_headers branch July 22, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JWhitleyWork JWhitleyWork JWhitleyWork approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @JWhitleyWork @clalancette