-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QoS overrides to stereo_image_proc #651
Add QoS overrides to stereo_image_proc #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nitpick
We should make sure the CI jobs are green before merging. Since this change is not compatible with Foxy, we should probably branch (FYI @JWhitleyWork). For Rolling, we should make releases for the changes to image_common and message_filters (I can help with that); for Galactic it may require backporting those changes (I'll check when releasing for Rolling). |
I think I'm going to make a PR to |
@JWhitleyWork Friendly ping for review. It sounds like we may also want to re-target this to a new |
@ros-pull-request-builder retest this please |
Tested this on ros2 galactic and ros2 rolling. It builds and passes all tests. I made two small edits to the package.xml files in this PR. |
Re-targeted |
@ros-pull-request-builder retest this please |
1 similar comment
@ros-pull-request-builder retest this please |
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
This is adding QoS overrides, which were added in ros2/rclcpp#1408.
This PR relies on