Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding [x]Props to every component #1368

Closed
32 tasks done
gretanausedaite opened this issue Jun 20, 2023 · 4 comments
Closed
32 tasks done

Adding [x]Props to every component #1368

gretanausedaite opened this issue Jun 20, 2023 · 4 comments
Assignees
Labels
react Needs change in react package

Comments

@gretanausedaite
Copy link
Contributor

gretanausedaite commented Jun 20, 2023

The goal is to allow adding a custom className (or data attribute) to every single dom node. For example: it should be possible to add a custom class to Button text, Checkbox wrapper, etc.

To do:

  • Go through each component and check if you can customize every part of it. Eg. Checkbox wrapper, checkbox, and checkbox label needs to be customizable.
  • For every non-customizable element in every component, add a new prop to allow that customisation where needed. Name it like [x]Props, e.g. wrapperProps in Checkbox.

Example usage from a consumer-perspective:

<Checkbox
  label='My checkbox'
  className='my-checkbox-input'
  wrapperProps={{ className: 'my-checkbox-wrapper' }}
  labelProps={{ className: 'my-checkbox-text' }}
/>

Status

High Priority:

Mid Priority:

Low Priority:

@gretanausedaite gretanausedaite added the react Needs change in react package label Jun 20, 2023
@Juliakas

This comment was marked as resolved.

@mayank99

This comment was marked as resolved.

@Juliakas

This comment was marked as resolved.

@siddhantrawal siddhantrawal removed their assignment Jan 31, 2024
@AdamMeza-Bentley

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react Needs change in react package
Projects
None yet
Development

No branches or pull requests

9 participants