Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [x]Props to ToggleSwitch #2010

Merged
merged 22 commits into from
Apr 25, 2024
Merged

Add [x]Props to ToggleSwitch #2010

merged 22 commits into from
Apr 25, 2024

Conversation

AdamMeza-Bentley
Copy link
Contributor

@AdamMeza-Bentley AdamMeza-Bentley commented Apr 18, 2024

Changes

Continues work on #1368 by adding optional labelProps to ToggleSwitch. I debated including a ``wrapperProps` as well but decided against it. I can always add those if they're wanted as well.

Testing

Added React testing for new labelProps functionality

Docs

Added a changeset

@AdamMeza-Bentley AdamMeza-Bentley marked this pull request as ready for review April 19, 2024 14:33
@AdamMeza-Bentley AdamMeza-Bentley requested review from a team as code owners April 19, 2024 14:33
@AdamMeza-Bentley AdamMeza-Bentley requested review from mayank99 and Ben-Pusey-Bentley and removed request for a team April 19, 2024 14:33
@AdamMeza-Bentley AdamMeza-Bentley merged commit 807acf1 into main Apr 25, 2024
16 checks passed
@AdamMeza-Bentley AdamMeza-Bentley deleted the Adam/ToggleSwitch-props branch April 25, 2024 19:20
@imodeljs-admin imodeljs-admin mentioned this pull request Apr 25, 2024
@AdamMeza-Bentley AdamMeza-Bentley self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants