Customisation effort: toast #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
gretanausedaite
requested review from
mayank99 and
r100-stack
and removed request for
a team
r100-stack
reviewed
Aug 23, 2023
Co-authored-by: Rohan Kadkol <[email protected]>
gretanausedaite
commented
Aug 23, 2023
mayank99
reviewed
Aug 23, 2023
mayank99
reviewed
Aug 24, 2023
r100-stack
reviewed
Aug 25, 2023
Co-authored-by: Rohan Kadkol <[email protected]>
mayank99
approved these changes
Aug 25, 2023
r100-stack
reviewed
Aug 28, 2023
| @@ -185,3 +185,26 @@ it('should close temporary toast after 7s', () => { | |||
|
|
|||
| jest.useRealTimers(); | |||
| }); | |||
|
|
|||
| it('should pass content props correctly', () => { | |||
There was a problem hiding this comment.
nit: Since earlier, we were using CommonProps (id, className, style), it is good to test if className and style are applied correctly without CommonProps, like you have it now.
But, you could also test if some other props apart from those three are passed correctly. E.g., onClick.
This is just an optional suggestion.
There was a problem hiding this comment.
Leaving it as is for now.
r100-stack
approved these changes
Aug 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
contentPropsTesting
Unit tests added
Docs
Changeset