-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tile composition #1255
Tile composition #1255
Conversation
@mayank99 can you briefly check if I'm going the right direction? before I try to complete the other subcomponents. Also I made a different file to work on incrementally rather than modifying existing Tile, easier for me this way. Once everything works right I'll deleted old Tile and rename new Tile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to review this in more detail tomorrow. For now, my only comment is to suggest making use of the polymorphic
utility from #1279 (see example below).
We can restructure the html/css. It was kept this way in #1125 for backwards compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpicky comment. Other than that, make sure the tests pass before you merge!
Fantastic job! 🎉
*/ | ||
export const Tile = Object.assign(TileComponent, { | ||
/** | ||
*ThumbnailArea subcomponent that contains `ThumbnailPicture`, `QuickAction`, `TypeIndicator` or `BadgeContainer` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a space before ThumbnailArea
on this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 😄 , and thanks!
@FlyersPh9 do you want to make a last check on the css/html of this? before I merge (if I manage to pass those image tests that is 😂 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work
…nto tile-composition
Changes
Convert most Tile's props into polymographic subcomponents with the following structure:
Testing
Docs