Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Button DOM Node customization #1435

Merged
merged 36 commits into from
Aug 10, 2023
Merged

Improving Button DOM Node customization #1435

merged 36 commits into from
Aug 10, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Jul 24, 2023

Changes

Adding props to Button that allows for individuation of each DOM-node.

Addresses #1368

Testing

Unit & visual testing to be conducted.

Docs

TBD

@xman343 xman343 mentioned this pull request Jul 24, 2023
Closed
32 tasks
@xman343 xman343 changed the title Adding [x]Props to Button Improving Button DOM Node customization Jul 24, 2023
@xman343 xman343 self-assigned this Jul 24, 2023
@xman343 xman343 marked this pull request as ready for review July 24, 2023 15:37
@xman343 xman343 requested review from a team as code owners July 24, 2023 15:37
@xman343 xman343 requested review from gretanausedaite and LostABike and removed request for a team July 24, 2023 15:37
@mayank99
Copy link
Contributor

Button changes look good. I would suggest also going through other variants of Button (e.g. IconButton, IdeasButton, SplitButton, etc) and testing them in the playground to get an understanding of what parts need to be customized. After that, the code can be updated in this same PR.

gretanausedaite
gretanausedaite reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button looks good 👍

gretanausedaite
gretanausedaite reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SplitButton needs some changes as well.

mayank99
mayank99 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayank99 mayank99 merged commit bd8a37c into dev Aug 10, 2023
@mayank99 mayank99 deleted the xander/button-xProps branch August 10, 2023 20:17
@imodeljs-admin imodeljs-admin mentioned this pull request Aug 9, 2023
Merged
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite approved these changes

@mayank99 mayank99 mayank99 approved these changes

@LostABike LostABike LostABike approved these changes

Assignees

@xman343 xman343

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xman343 @mayank99 @LostABike @gretanausedaite