allow tags to be used as buttons #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
r100-stack
reviewed
Feb 5, 2024
Co-authored-by: Rohan Kadkol <[email protected]>
Merged
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed unnecessary styles from tag and added the ability for it to be used on
<button>elements. Two of the most prominent changes:user-selectbecause it interferes with clickability and provides no benefitfocus-withinstyles, because tag itself can be focusable (when used as button)In react, the
onClickprop will be used to automatically change the rendered element to"button".Additionally,
labelPropsandremoveButtonPropshave been added for further customization of inner parts.All of this together addresses a user request where they want to use tags as interactive elements.
Testing
Added unit tests + story.
Updated failing visual tests.
Docs
Updated jsdocs. Added changesets.
Not sure if we should document the "clickable" use-case, because tags were not supposed to be interactive in the first place.