add new props for customizing internal Modal elements
#1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
AdamMeza-Bentley
and removed request for
a team
mayank99
commented
Feb 5, 2024
| @@ -99,10 +114,11 @@ export const Modal = React.forwardRef((props, forwardedRef) => { | |||
| setFocus | |||
| ref={forwardedRef} | |||
There was a problem hiding this comment.
This part is very annoying: ref and ...rest props are applied on different elements. I thought we fixed it in v3, but evidently not.
mayank99
changed the title
Modal elementsModal elements
r100-stack
approved these changes
Feb 5, 2024
mayank99
changed the title
Modal elementsModal elements
Merged
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses second point of #1368 (comment)
Testing
Added unit tests for new props.
Docs
Added changesets.