-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(project): add elements packages #2418
Merged
joshblack
merged 491 commits into
carbon-design-system:master
from
joshblack:refactor/add-elements-packages
May 8, 2019
Merged
refactor(project): add elements packages #2418
joshblack
merged 491 commits into
carbon-design-system:master
from
joshblack:refactor/add-elements-packages
May 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(icon-helpers): add usage section * docs: add missing usage docs for packages * chore(project): run sync
* feat(elements): add @carbon/elements package * chore(project): run sync * chore(elements): add additional build folders to clean task
…gn-system#202) * Value update for expressive-heading-04 token expressive-heading-04 values at sm, med, and large breakpoints were updated in order to prevent our H1 and H2s from becoming that same size at mobile and tablet. * chore(type): update expressiveHeading04 * chore(test): update snapshots
* feat: added fluid spacing token * docs: updated demo with fluid spacing
$expressive-heading-04 was using Regular (400) weight all the way through; we've changed 28px and above to use Light (300), in order to match $expressive-heading-05 weights.
* refactor(colors): update to scss pattern * docs(colors): add initial contributing docs for color * chore(test): update snapshots * fix(colors): use global flag for variable assignment * chore(test): update snapshots
…on-design-system#219) * Update $productive-heading-05 to Light weight $expressive-heading-04 and -05 are using the light weight at 28px; $productive-heading-05 needs to be updated to match. * chore(type): sync to styles and snapshots
* feat: added fluid spacing token * docs: updated demo with fluid spacing * feat: added grid--full-width modifier * docs: updated demos to reflect new changes to grid
…#222) * docs: run doctoc and add skeleton for design.md * feat(bundler): add support for scss compilation * feat(bundler): add support for scss compilation * chore: add bundle entrypoint for packages to generate css * chore: sync offline mirror
…bon-design-system#223) * chore(package): add icons to ignore patterns and update ci-check * chore(project): fix ci-check command * chore(test): update ignore pattern for examples
There were conflicting weights on the IDL site; the brand team likes to use light weight on black backgrounds and regular weight on light backgrounds for the same size fonts. We have to pick a lane and stick with the regular weight for $expressive-heading-04 (all steps) $expressive-heading-05 (step 7) and $productive-heading-04. Basically reverting back to what we had before... apologize for the confusion.
…n-design-system#231) * feat(icons-react): forward React refs to rendered SVG element * test(icons-react): add test for forwarding refs to rendered SVGs * test(icons-react): remove `fit` method Co-Authored-By: emyarod <[email protected]> * test(icons-react): remove duplicate assertion * style(icons-react): format template string
* refactor(colors): move tokens out of colors package * feat(themes): add themes package * docs: run doctoc and update colors guide * chore: run sync * chore(project): update offline mirror * chore(project): add scss to gitignore in themes
…-design-system#512) * Update type tokens * chore(type): sync changes to sass
* Stalebot. Add exemptions after this runs once * Update stale.yml
* Added `inner-path` adornments to misuse.svg, checkmark--filled.svg Added `inner-path` adornments to misuse.svg, checkmark--filled.svg; created all 4 sizes. adronment opacity and fill can now be styled by targeting the `inner-path`. * Add error--filled.svg, normalize other notifications icons Added 20, 24 sizes of error--filled with stylable `inner-path`. Adjusted others to normalize size, layer order, inner-path New: 20/error--filled.svg 24/error--filled.svg Changed: 16/error--filled.svg 16/warning--filled.svg 20/warning--filled.svg 24/checkmark--filled.svg 24/misuse.svg 24/warning--filled.svg 32/checkmark--filled.svg 32/error--filled.svg 32/warning--filled.svg * update 16/warning--filled.svg fix off center inner elements * update 16/warning--filled.svg * Update 20/warning--filled.svg * creat 20, 24 arrow--right.svg Since it's in the site banner, created 20 and 24 versions of arrow--right.svg * adds 16/chevron--mini.svg adds 16/chevron--mini.svg to support https://github.com/carbon-design-system/carbon-elements/issues/361
feat(icons) add /icons/master/ui-icon-master.ai
Deploy preview for the-carbon-components failed. Built with commit cc138ea https://app.netlify.com/sites/the-carbon-components/deploys/5cd33dda762acb0008c9c3dc |
tw15egan
approved these changes
May 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Überrepo 🙏 👍
dakahn
approved these changes
May 8, 2019
…nents into refactor/add-elements-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2385, depends on #2417
Add elements package to the project.
Reviewer checklist:
yarn build
yarn ci-check